Re: [pgAdmin][SonarQube] Fixes for 13 rules.

2020-08-03 Thread Akshay Joshi
Thanks, patch applied. On Mon, Aug 3, 2020 at 12:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix around 27 SonarQube related issues raised for > rules: > >1. Remove this assignment to the local variable, the value is never >

[pgAdmin][SonarQube] Fixes for 13 rules.

2020-08-03 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix around 27 SonarQube related issues raised for rules: 1. Remove this assignment to the local variable, the value is never used. 2. Rename local variables to match the regular expression 3. Add logic to this except clause or eliminate it and rethrow