Thanks, patch applied.
On Thu, Sep 3, 2020 at 7:19 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:
> Hi Akshay,
>
> Please find the updated patch.
>
>
> On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi
> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments:
>>
>>- ROLE_NOT_FO
Hi Akshay,
Please find the updated patch.
On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi
wrote:
> Hi Pradip
>
> Following are the review comments:
>
>- ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
>like gone(_(ROLE_NOT_FOUND)). In fact, can we use
>
>self.not_fou
Hi Pradip
Following are the review comments:
- ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
like gone(_(ROLE_NOT_FOUND)). In fact, can we use
self.not_found_error_msg()instead of new constant.
- Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,
Hi Hackers,
Attached is a patch for removing duplicates string literals.
/server_groups/servers/roles/__init__.py - 8 places
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
sonar_Qube_v1.patch
Description: Binary data
