Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 14, 2022 at 6:03 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for resql test cases failure. > > > *Thanks & Regards,* > > *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* > > > On Mon

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-14 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for resql test cases failure. *Thanks & Regards,* *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* On Mon, Jun 13, 2022 at 6:21 PM Akshay Joshi wrote: > Hi Pradip > > The fix is not correct as it is still failing for PG and PPAS. Please

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-13 Thread Akshay Joshi
Hi Pradip The fix is not correct as it is still failing for PG and PPAS. Please investigate and send the proper fix. On Mon, Jun 13, 2022 at 5:08 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for RESQL test cases failure. > > > *Thank

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-13 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for RESQL test cases failure. *Thanks & Regards,* *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* On Mon, Jun 13, 2022 at 2:51 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Jun 13, 2022 at 12:56 PM Pradip Parkale < > p

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-13 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 13, 2022 at 12:56 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. I have fixed all the issues. > > *Thanks & Regards,* > > *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* > > > On Fri,

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-10 Thread Dave Page
On Fri, 10 Jun 2022 at 07:21, Akshay Joshi wrote: > > On Thu, Jun 9, 2022 at 2:27 PM Dave Page wrote: > >> >> >> On Thu, 9 Jun 2022 at 09:47, Pradip Parkale < >> pradip.park...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi >>> wrote: >>> On Thu

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
On Thu, Jun 9, 2022 at 2:27 PM Dave Page wrote: > > > On Thu, 9 Jun 2022 at 09:47, Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi >> wrote: >> >>> >>> >>> On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: >>> On Thu,

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Dave Page
On Thu, 9 Jun 2022 at 09:47, Pradip Parkale wrote: > > > On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi > wrote: > >> >> >> On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: >> >>> >>> >>> On Thu, 9 Jun 2022 at 08:16, Akshay Joshi >>> wrote: >>> Hi Pradip Following are the review comme

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Pradip Parkale
On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi wrote: > > > On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: > >> >> >> On Thu, 9 Jun 2022 at 08:16, Akshay Joshi >> wrote: >> >>> Hi Pradip >>> >>> Following are the review comments: >>> >>> >>>- 'show user defined templates' in preferences should

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: > > > On Thu, 9 Jun 2022 at 08:16, Akshay Joshi > wrote: > >> Hi Pradip >> >> Following are the review comments: >> >> >>- 'show user defined templates' in preferences should be ''show user >>defined template databases'. >> >> Is it just us

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Dave Page
On Thu, 9 Jun 2022 at 08:16, Akshay Joshi wrote: > Hi Pradip > > Following are the review comments: > > >- 'show user defined templates' in preferences should be ''show user >defined template databases'. > > Is it just user defined ones, or does it include template0/template1? > >- >

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
Hi Pradip Following are the review comments: - 'show user defined templates' in preferences should be ''show user defined template databases'. - Help message for 'Template?' should be changed to "Note: When the preferences setting 'show user defined templates' is set to false, then

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-06 Thread Dave Page
On Mon, 6 Jun 2022 at 10:30, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Mon, Jun 6, 2022 at 2:20 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jun 6, 2022 at 2:17 PM Dave Page wrote: >> >>> >>> >>> On Fri, 3 Jun 2022 at 08:26, Akshay J

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-06 Thread Aditya Toshniwal
On Mon, Jun 6, 2022 at 2:20 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jun 6, 2022 at 2:17 PM Dave Page wrote: > >> >> >> On Fri, 3 Jun 2022 at 08:26, Akshay Joshi >> wrote: >> >>> Hi Pradip >>> >>> Following are the review comments: >>> >>>- Fixed pep8 issues.

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-06 Thread Khushboo Vashi
On Mon, Jun 6, 2022 at 2:17 PM Dave Page wrote: > > > On Fri, 3 Jun 2022 at 08:26, Akshay Joshi > wrote: > >> Hi Pradip >> >> Following are the review comments: >> >>- Fixed pep8 issues. >>- Documentation updates are missing. >>- In the 'alter_online.sql' file correct the comment abo

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-06 Thread Dave Page
On Fri, 3 Jun 2022 at 08:26, Akshay Joshi wrote: > Hi Pradip > > Following are the review comments: > >- Fixed pep8 issues. >- Documentation updates are missing. >- In the 'alter_online.sql' file correct the comment above the ALTER >statement. Also, remove one extra space after "I

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-03 Thread Akshay Joshi
Hi Pradip Following are the review comments: - Fixed pep8 issues. - Documentation updates are missing. - In the 'alter_online.sql' file correct the comment above the ALTER statement. Also, remove one extra space after "IS_TEMPLATE". Do this in both the files. - Remove extra spac

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-01 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #7351. I have made all the necessary changes which were discussed. *Thanks & Regards,* *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* On Wed, May 18, 2022 at 7:11 PM Dave Page wrote: > Hi > > On Wed, 18 May 2022 at 14:02, Pradip

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-18 Thread Dave Page
Hi On Wed, 18 May 2022 at 14:02, Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Dave/Team, > > I have come up with a plan to implement this. Please give your suggestions > > >1. Users will be able to hide user-defined templates in the >preferences setting. By default, the v

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-18 Thread Pradip Parkale
Hi Dave/Team, I have come up with a plan to implement this. Please give your suggestions 1. Users will be able to hide user-defined templates in the preferences setting. By default, the value is 'Yes', and all user-defined templates will be hidden. 2. The icon will be different for u

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-17 Thread Dave Page
On Tue, 17 May 2022 at 08:08, Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Dave/Team, > > On Wed, May 11, 2022 at 4:37 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, May 11, 2022 at 4:03 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, 11 Ma

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-17 Thread Pradip Parkale
Hi Dave/Team, On Wed, May 11, 2022 at 4:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, May 11, 2022 at 4:03 PM Dave Page wrote: > >> Hi >> >> On Wed, 11 May 2022 at 09:40, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Aditya Toshniwal
Hi, On Wed, May 11, 2022 at 4:03 PM Dave Page wrote: > Hi > > On Wed, 11 May 2022 at 09:40, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, May 11, 2022 at 2:00 PM Dave Page wrote: >> >>> >>> >>> On Wed, 11 May 2022 at 09:24, Aditya Toshniwal < >>> adi

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Dave Page
Hi On Wed, 11 May 2022 at 09:40, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, May 11, 2022 at 2:00 PM Dave Page wrote: > >> >> >> On Wed, 11 May 2022 at 09:24, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, May 11

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Aditya Toshniwal
Hi Dave, On Wed, May 11, 2022 at 2:00 PM Dave Page wrote: > > > On Wed, 11 May 2022 at 09:24, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, May 11, 2022 at 1:24 PM Dave Page wrote: >> >>> Hi >>> >>> I think this change needs some thought and discussion on

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Dave Page
On Wed, 11 May 2022 at 09:24, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, May 11, 2022 at 1:24 PM Dave Page wrote: > >> Hi >> >> I think this change needs some thought and discussion on how it should be >> implemented. pgAdmin has worked this way for over 20 yea

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Pradip Parkale
Hi, On Wed, May 11, 2022 at 1:54 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, May 11, 2022 at 1:24 PM Dave Page wrote: > >> Hi >> >> I think this change needs some thought and discussion on how it should be >> implemented. pgAdmin has worked this way for over

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Aditya Toshniwal
Hi, On Wed, May 11, 2022 at 1:24 PM Dave Page wrote: > Hi > > I think this change needs some thought and discussion on how it should be > implemented. pgAdmin has worked this way for over 20 years with only this > one suggestion to change afaicr - and I for one don't suddenly want > templates sh

Re: [pgAdmin][RM7351]: Templates not displayed

2022-05-11 Thread Dave Page
Hi I think this change needs some thought and discussion on how it should be implemented. pgAdmin has worked this way for over 20 years with only this one suggestion to change afaicr - and I for one don't suddenly want templates showing up amongst my other databases. On Wed, 11 May 2022 at 07:12,

[pgAdmin][RM7351]: Templates not displayed

2022-05-10 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for # 7351:Templates not displayed. I have fixed below issues 1. Databases which are marked as template manually by the user should be visible independent of - "Show System Objects". 2. DB properties dialogs should allow you to change template