Re: [pgAdmin][RM7313] Port file manager to ReactJS

2022-07-24 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jul 25, 2022 at 11:22 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached patch fixes: > 1. Intermittently failing test cases. > 2. Dialog vertical position should be more on the upper side. > 3. File not supported error is not sho

Re: [pgAdmin][RM7313] Port file manager to ReactJS

2022-07-24 Thread Aditya Toshniwal
Hi, Attached patch fixes: 1. Intermittently failing test cases. 2. Dialog vertical position should be more on the upper side. 3. File not supported error is not showing. Please review. On Tue, Jul 19, 2022 at 3:30 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Jul 18, 2022 at

Re: [pgAdmin][RM7313] Port file manager to ReactJS

2022-07-19 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jul 18, 2022 at 6:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch and inline comments. > > On Thu, Jul 14, 2022 at 5:23 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >>

Re: [pgAdmin][RM7313] Port file manager to ReactJS

2022-07-14 Thread Akshay Joshi
Hi Aditya Following are the review comments: GUI: - By default files/folders are not visible. - The select button should be disabled until the file/folder is not selected, to reproduce open the dialog select any file, and then change the file format, the select button should be disab