Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-14 Thread Pradip Parkale
Hi Aditya and Akshay, Please find the updated patch. I have changed the variable name "data" to 'numeric_cols'. On Fri, Jun 11, 2021 at 7:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Pradip, > > Just did a go through to your patch. > The variable "data" which you've fo

Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-11 Thread Aditya Toshniwal
Hi Pradip, Just did a go through to your patch. The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations. Secondly, it should not be named as data. It can be lik

[pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6520.patch Description: Binary data