Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-10 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 10, 2021 at 4:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The preview images for the themes are not visible after this. Please find > the attached patch to fix. > > On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi < > akshay.jo...@en

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-10 Thread Aditya Toshniwal
Hi, The preview images for the themes are not visible after this. Please find the attached patch to fix. On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >>

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-10 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The imagemin-gifsicle package is used to compress gif images. The latest > version of imagemin-gifsicle requires the binaries to be built from source, > which has a big de

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-10 Thread Aditya Toshniwal
Hi, The imagemin-gifsicle package is used to compress gif images. The latest version of imagemin-gifsicle requires the binaries to be built from source, which has a big dependency of dh-autoreconf. pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've removed imagemin-gifsicle from

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-09 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> One jasmine test is failing, please fix that and resend the patch. >> > It was failing because

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-09 Thread Akshay Joshi
Hi Aditya One jasmine test is failing, please fix that and resend the patch. On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to update the JS dependencies to latest. Changes > include: > 1) Migrate from webpack 4