Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-08-03 Thread Akshay Joshi
Hi Rahul Fixed the issue by modifying the condition from 'is false' to ' == false'. On Fri, Jul 31, 2020 at 12:42 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > A syntactical error in a jinja template caught yesterday in Yogesh's local > setup of pgAdmin by running a

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-31 Thread Rahul Shirsat
Hi Akshay, A syntactical error in a jinja template caught yesterday in Yogesh's local setup of pgAdmin by running a test suite for the changes done in this RM. It's strange going through several testings, even on Jenkins, it passed but failed on Yogesh's machine. I have made changes for this issu

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-29 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Ignore the previous patch. Find below the rebased patch. > > On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >>

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-29 Thread Rahul Shirsat
Hi Hackers, Ignore the previous patch. Find below the rebased patch. On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch below which fixes the issue of Start value while > updating the identity column. > > *Some additiona

[pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-29 Thread Rahul Shirsat
Hi Hackers, Please find the patch below which fixes the issue of Start value while updating the identity column. *Some additional issues were also found during development, which are too fixed now :* 1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence options, it onl