Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-03-06 Thread Akshay Joshi
Thanks, patch applied. On Thu, Mar 5, 2020 at 6:02 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Please find the updated patch for RM5143. > > > On Tue, Feb 25, 2020 at 6:26 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> O

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-03-05 Thread Pradip Parkale
Hi Hackers, Please find the updated patch for RM5143. On Tue, Feb 25, 2020 at 6:26 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay/Aditya, >> >> Please find the updated patch. I have ac

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-25 Thread Akshay Joshi
Thanks, patch applied. On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. I have accommodated all the changes. > > > On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com>

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-25 Thread Pradip Parkale
Hi Akshay/Aditya, Please find the updated patch. I have accommodated all the changes. On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Pradip, > > - > > commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content > div.active

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-24 Thread Aditya Toshniwal
Hi Pradip, - commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content div.active')); + $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus(); Use the same common function with commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)).

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-20 Thread Akshay Joshi
Hi Aditya Can you please review this patch. On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Please find the attached patch. > > On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Forgot to attach the patch? >> >>

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Pradip Parkale
Please find the attached patch. On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi wrote: > Forgot to attach the patch? > > On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is a patch for accessibility issue related Alertifyjs. >>

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Ashesh Vashi
Forgot to attach the patch? On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch for accessibility issue related Alertifyjs. > >1. Added hidden label to satisfy accessibility. >2. Added label with sr-only class. >

[pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Pradip Parkale
Hi Hackers, Attached is a patch for accessibility issue related Alertifyjs. 1. Added hidden label to satisfy accessibility. 2. Added label with sr-only class. 3. Added tabindex to move the mouse control to the maximize button using the tab key. Please note that this patch also inclu