Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-26 Thread Aditya Toshniwal
Hi Hackers, Turned out my pip was of older version. Upgrading pip solved the jaraco.functools problem. pip downloaded the suitable version automatically. Kindly ignore the previous patch. On Tue, Dec 24, 2019 at 12:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers,

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-23 Thread Aditya Toshniwal
Hi Hackers, One of the dependencies of cheroot - jaraco.functools was released on 20th Dec (v 3.0.0) which removed the support below Python 3.6. So while installing cheroot (using pgAdmin wheel) on Python 3.5, it is failing. cheroot works fine with its previous version of jaraco.functools==2.0.0.

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-20 Thread Aditya Toshniwal
Hi Ashesh, I had tried with - https://newrelic.com/ API to check Flask app performance. To be honest, there was not a great difference in the performance. Per new relic, cheroot used slightly less CPU, with more RPM and, with less response time. Anyway, flask is still not recommended and cheroot l

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-20 Thread Ashesh Vashi
Have you seen any improvements in performance? On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use https://pypi.org/project/cheroot/ instead of > current flask dev server. cheroot is a stable production ready serv

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-19 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 17, 2019 at 3:16 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use https://pypi.org/project/cheroot/ instead of > current flask dev server. cheroot is a stable production ready server. > Plus, flask de

[pgAdmin][RM5017] Use cheroot as default production server

2019-12-17 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to use https://pypi.org/project/cheroot/ instead of current flask dev server. cheroot is a stable production ready server. Plus, flask dev server is not recommended for production. Code is changed to use cheroot only when DEBUG is False, otherwise you the default