Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-25 Thread Akshay Joshi
Thanks, patch applied. On Mon, Nov 25, 2019 at 12:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix the review comments. > > On Thu, Nov 21, 2019 at 4:48 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Adity

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-21 Thread Akshay Joshi
Hi Aditya Following are the review comments: - Update the timeout in the comment section from 30 seconds to 10 seconds in aff1436e3c8c_.py. - Asking for the database server password even if it is saved. Reproduction steps: - Connect to the database server, saved the password. - Disable

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-20 Thread Aditya Toshniwal
Hi, I forgot to mention, I've also changed the dashboard code. The dashboard was sending graph data requests, but when the server lost connection the requests remains pending for longer time. Because of this the server gets flooded with lot of pending request and in turn slowing down the entire ap

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-20 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch to fix the review comments. Please note, there is some problem with psycopg2/libpq where it hangs when network is lost - https://github.com/psycopg/psycopg2/issues/561 I've also changed the code to make connections after the "Servers" node is expanded to f

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-15 Thread Akshay Joshi
Hi Aditya Following are the review comments: 1. The default connection timeout should be *10* seconds. 2. In case the network is disabled and when we expand the "Servers" node the database server(for which network is disabled) should be shown in the disconnected state. 3. For the

[pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-13 Thread Aditya Toshniwal
Hi Hackers, Attached is the workaround patch to set the default connection timeout to 30 seconds instead of the current value of infinite - 0, zero. The input is present in the server properties dialogs advanced tab. The workaround applies to the RM4724 as well. The permanent solution would be to