Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Akshay Joshi
Thanks, patch applied. On Tue, Oct 1, 2019 at 4:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Oct 1, 2019 at 3:58 PM Dave Page wrote: > >> >> >> On Tue, Oct 1, 2019 at 11:27 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Oct 1

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Khushboo Vashi
On Tue, Oct 1, 2019 at 3:58 PM Dave Page wrote: > > > On Tue, Oct 1, 2019 at 11:27 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Oct 1, 2019 at 3:55 PM Dave Page wrote: >> >>> >>> >>> On Tue, Oct 1, 2019 at 11:21 AM Khushboo Vashi < >>> khushboo.va...@enterpris

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Dave Page
On Tue, Oct 1, 2019 at 11:27 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Oct 1, 2019 at 3:55 PM Dave Page wrote: > >> >> >> On Tue, Oct 1, 2019 at 11:21 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Oct 1, 2019 at 3:16 PM Adity

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Khushboo Vashi
On Tue, Oct 1, 2019 at 3:55 PM Dave Page wrote: > > > On Tue, Oct 1, 2019 at 11:21 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Oct 1, 2019 at 3:16 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the upd

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Dave Page
On Tue, Oct 1, 2019 at 11:21 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Oct 1, 2019 at 3:16 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch. >> Changes are made to not to apply ProxyFix if it is n

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Khushboo Vashi
On Tue, Oct 1, 2019 at 3:16 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. > Changes are made to not to apply ProxyFix if it is not available. Plus, > requirements.txt is updated to Werkzeug>=0.15.0 > > It looks good to me except W

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Changes are made to not to apply ProxyFix if it is not available. Plus, requirements.txt is updated to Werkzeug>=0.15.0 Kindly review. On Tue, Oct 1, 2019 at 2:07 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > I forgot to c

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Murtuza Zabuawala
Hi, I forgot to change the virtualenv in another terminal Tab, I am getting error TypeError: __init__() got an unexpected keyword argument ‘x_for’ with Flask 1.0.2. Regards, Murtuza On Tue, Oct 1, 2019 at 1:35 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Aditya, > >

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-10-01 Thread Murtuza Zabuawala
Hi Aditya, Tested with below version and works fine. >>> flask.__version__ '1.0.2' >>> werkzeug.__version__ '0.14.1' -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Oct 1, 2019 at 12:04 PM Aditya Toshniwal < aditya.toshni...@e

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-09-30 Thread Aditya Toshniwal
Hi Hackers, I have added a backward compatible code in cases werkzeug is older. This will never happen considering we use Flask 1.0.2. Attached is the precautionary patch. On Fri, Sep 27, 2019 at 1:29 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Sep 27, 2019 at 12:17 PM Aditya To

Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

2019-09-27 Thread Akshay Joshi
Thanks, patch applied. On Fri, Sep 27, 2019 at 12:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow pgAdmin to run behind reverse proxy on a > non standard port. > The middleware - > https://werkzeug.palletsprojects.com/en/0.15.x/m

[pgAdmin][RM4768] Reverse proxy on non-standard port

2019-09-26 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to allow pgAdmin to run behind reverse proxy on a non standard port. The middleware - https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#werkzeug.middleware.proxy_fix.ProxyFix allows us to set the number of trusted ports (and few other params) be