Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

2019-11-24 Thread Akshay Joshi
Thanks, patch applied. On Sat, Nov 23, 2019 at 12:37 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Akshay, > > Please find the correction done in this updated patch based on your review > comments. > > Regards, > Rahul Shirsat. > > On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi < > ak

Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

2019-11-20 Thread Akshay Joshi
Hi Rahul Some more review comments: - Don't create new file test_view.json as I tested and committed the old code. - Remove hardcoded "oid: 17869" from JSON file. - MSQL endpoints and file name missing in some test cases. - Cover all the controls in create and alter as much as poss

Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

2019-11-19 Thread Akshay Joshi
Hi Rahul Test cases failing on all EPAS servers. Please fix and send the patch again. On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > I have attached the patch for RE-SQL/MSQL test cases for View as well as > Materialized View. > > -- > *

[pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

2019-11-18 Thread Rahul Shirsat
Hi Hackers, I have attached the patch for RE-SQL/MSQL test cases for View as well as Materialized View. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM4696.patch Description: Binary data