Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-29 Thread Akshay Joshi
Thanks patch applied. On Thu, Aug 29, 2019 at 12:29 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. > The patch also includes some RE-SQL log additions and a change in resql > code where msql was failing if scenario data had dict da

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-29 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. The patch also includes some RE-SQL log additions and a change in resql code where msql was failing if scenario data had dict data types. Code is changed to convert dict to string before forming the URL. Kindly review. On Thu, Aug 29, 2019 at 11:28 AM A

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-28 Thread Aditya Toshniwal
Hi Hackers, Kindly hold on with the patch. I think I have missed few things. :P Will send an updated patch. On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch containing further changes to sequences RE-SQL test > c

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-08-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers. Kindly review. On Mon, Jul 15, 2019 at 7:26 PM Dave Page wrote: > Thanks, committed. > > On Mon, Jul

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-07-15 Thread Dave Page
Thanks, committed. On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add RE-SQL test cases for sequences. When running > the test cases, I also found an issue (#4470 >

[pgAdmin][RM4469] Add RE-SQL test cases for Sequences

2019-07-15 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470 ). The fix for it is included in the patch. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer |