Thanks patch applied.
On Tue, Jul 2, 2019 at 2:51 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch. Instead of float comparison, string
> comparison is done now with the help of a nice article here -
> http://www.arvydas.co.uk/2015/04
Hi Hackers,
Attached is the updated patch. Instead of float comparison, string
comparison is done now with the help of a nice article here -
http://www.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/
Kindly review.
On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi
wrote:
> Hi Aditya
>
Hi Aditya
I have asked Paresh to review the patch, he has given some review comments.
Please fix those and the updated patch asap.
On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix a potential issue where ve
Hi Hackers,
Attached is the patch to fix a potential issue where version compare while
upgrading will be incorrect. Currently, it is comparing strings. So while
comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.
Kindly review.
--
