Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-20 Thread Dave Page
Thanks all! On Wed, Nov 20, 2019 at 4:37 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run >> bundle" an

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-20 Thread Akshay Joshi
Thanks, patch applied. On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run > bundle" and is copied to generated directory also. This file is required > for themes to

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-19 Thread Aditya Toshniwal
Hi Hackers, pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run bundle" and is copied to generated directory also. This file is required for themes to show up. Currently, pgadmin.themes.json file is referred from web/pgadmin/misc/themes directory by the app. It is better to refe

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-12 Thread Akshay Joshi
Thanks, patch applied. On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to set browser autofill color. I've used primary > light color to highlight autofill. Note that, this works only on webkit > browsers. > Kin

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-12 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to set browser autofill color. I've used primary light color to highlight autofill. Note that, this works only on webkit browsers. Kindly review. On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue,

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-12 Thread Aditya Toshniwal
Hi Dave, On Tue, Nov 12, 2019 at 7:29 PM Dave Page wrote: > > > On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to customize the scrollbar styling. A new SASS >> variable added - $scrollbar-base-color is

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-12 Thread Dave Page
On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to customize the scrollbar styling. A new SASS > variable added - $scrollbar-base-color is added to change the color as per > theme. > Please note, customization of

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Dave Page
Hi On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Nov 11, 2019, 20:33 Dave Page wrote: > >> Hi >> >> That's looking a lot better. I see a couple of issues (screenshots >> attached): >> >> - The combo box on the query tool toolb

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Aditya Toshniwal
Hi Dave, On Mon, Nov 11, 2019, 20:33 Dave Page wrote: > Hi > > That's looking a lot better. I see a couple of issues (screenshots > attached): > > - The combo box on the query tool toolbar isn't dark. > I'm not sure why you are not able to see it but I've changed it. Try a python restart. > - T

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Dave Page
Hi That's looking a lot better. I see a couple of issues (screenshots attached): - The combo box on the query tool toolbar isn't dark. - The tagline on the dashboard logo isn't readable. A couple of other thoughts: - The guide lines on the graphs are still too bright. Let's make them the same c

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Akshay Joshi
Thanks, patch applied. As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components. On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Kindly review. On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Kindly hold on with the patch. Few more changes required per review by @Ashesh > Vashi . > > On Mon, Nov 11, 2019 at 3:07 PM Aditya To

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Aditya Toshniwal
Hi, Kindly hold on with the patch. Few more changes required per review by @Ashesh Vashi . On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for further improvements in the Dark theme colors. > Gray shades and ot

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch for further improvements in the Dark theme colors. Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that. Few dashboard graph related changes. As suggested,

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Aditya Toshniwal
Hi Dave, On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote: > Hi > > On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: >> >>> >>> >>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: >

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-11 Thread Dave Page
Hi On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: > >> >> >> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: >> >>> >>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >>> akshay.jo...@ent

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-10 Thread Aditya Toshniwal
Hi Dave, On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: > > > On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: > >> >> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-07 Thread Dave Page
On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: > > On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch with

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-07 Thread Dave Page
On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch with few more changes and corrections. >> Kindly review. >> > I've com

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-07 Thread Akshay Joshi
Thanks, patch applied. On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch with few more changes and corrections. > Kindly review. > > On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal < > aditya.toshni...@ente