Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-07-03 Thread Dave Page
Thanks, applied. On Tue, Jul 2, 2019 at 8:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The SUMMARY data will be visible on hover > over the top-right icon along JIT stats and Triggers (if any). > I'm not sure where does SETTIN

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-28 Thread Dave Page
Hi On Fri, Jun 28, 2019 at 9:27 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to fix the review comments of trailing mail. > Kindly review. > So where is the summary supposed to be displayed? It's now requesting it from the server

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch to fix the review comments of trailing mail. Kindly review. On Thu, Jun 27, 2019 at 4:49 PM Dave Page wrote: > Hi > > On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-27 Thread Dave Page
Hi On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > >> Hi >> >> Something isn't working correctly - I turned on the summary option, and >> this is the query that was run when I hit the EXPLA

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-26 Thread Aditya Toshniwal
Hi, On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > Hi > > Something isn't working correctly - I turned on the summary option, and > this is the query that was run when I hit the EXPLAIN button: > > EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING > False,SUMMARY False,BUFF

Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-26 Thread Dave Page
Hi Something isn't working correctly - I turned on the summary option, and this is the query that was run when I hit the EXPLAIN button: EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS False) select * from pg_tables Aside from the formatting (s/Tru

[pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY

2019-06-26 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) explain options. These options will be visible only if version is supported. I have also created and fixed RM4395. The explain options changed on one query tool should not change explain options on other query t