Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-27 Thread Dave Page
Thanks, applied. On Thu, Jun 27, 2019 at 6:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch based on the review comments in > trailing mail. > Kindly review. > > On Wed, Jun 26, 2019 at 5:09 PM Dave Page wrote: > >> >> >> On Wed,

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-27 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch based on the review comments in trailing mail. Kindly review. On Wed, Jun 26, 2019 at 5:09 PM Dave Page wrote: > > > On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at 5:

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-26 Thread Dave Page
On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 5:06 PM Dave Page wrote: > >> >> >> On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 26, 201

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-26 Thread Aditya Toshniwal
Hi, On Wed, Jun 26, 2019 at 5:06 PM Dave Page wrote: > > > On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < >>> adit

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-26 Thread Dave Page
On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-26 Thread Aditya Toshniwal
Hi, On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: > Hi > > On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to allow tree nodes to be dragged and dropped in >> query editor wherever you take the drop cu

Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-26 Thread Dave Page
Hi On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow tree nodes to be dragged and dropped in > query editor wherever you take the drop cursor. The drop text will be fully > qualified and double quoted if r

[pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-25 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to allow tree nodes to be dragged and dropped in query editor wherever you take the drop cursor. The drop text will be fully qualified and double quoted if required. For functions/procedures it will drop the the label stripping away the parameter names, with empty