Thanks, patch applied. Fixed some minor issues.
On Mon, Apr 6, 2020 at 3:52 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Please find the attached rebased patch.
>
> On Mon, Apr 6, 2020 at 3:22 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
Hi Aditya,
Please resend the rebased patch, it does not apply.
Thanks,
Khushboo
On Fri, Apr 3, 2020 at 2:44 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the updated patch.
> With this,
> 1) I've displayed the rows count detail at the bottom of th
Hi Khushboo,
On Thu, Apr 2, 2020 at 4:49 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
>
> On Thu, Apr 2, 2020 at 4:30 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Khushboo,
>>
>> Thank you for reviewing.
>>
>>
>> On Thu, Apr 2, 2020 at 4:09 PM Khushbo
On Thu, Apr 2, 2020 at 4:30 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Khushboo,
>
> Thank you for reviewing.
>
>
> On Thu, Apr 2, 2020 at 4:09 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Aditya,
>>
>> Review comments:
>>
>> *UI:*
>>
>> 1. When n
Hi Khushboo,
Thank you for reviewing.
On Thu, Apr 2, 2020 at 4:09 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Aditya,
>
> Review comments:
>
> *UI:*
>
> 1. When no object is found, the default message should be given, currently
> no message displayed.
> 2. Can we have a too
Hi Aditya,
Review comments:
*UI:*
1. When no object is found, the default message should be given, currently
no message displayed.
2. Can we have a tooltip on the row "Double click to locate the object in
the browser" ?
3. Full stop is missing in the message column objects are disabled in the
br
On Wed, Apr 1, 2020 at 6:00 PM Akshay Joshi
wrote:
> Hi Khushboo,
>
> Can you please review it.
>
I am on it.
>
> On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to implement search objects functionality
Hi Khushboo,
Can you please review it.
On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch to implement search objects functionality in pgadmin.
> The feature will allow a user to search for any object in a database
Hi Khsuboo,
Can you please review it.
On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch to implement search objects functionality in pgadmin.
> The feature will allow a user to search for any object in a database.
