Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-02-03 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 3, 2021 at 2:22 PM Nikhil Mohite wrote: > Hi Team, > > Please find the updated patch for RM-6143. > > > Regards, > Nikhil Mohite. > > On Mon, Feb 1, 2021 at 2:52 PM Dave Page wrote: > >> Hi >> >> On Mon, Feb 1, 2021 at 7:51 AM Nikhil Mohite < >> nikhil.moh...@

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-02-01 Thread Dave Page
Hi On Mon, Feb 1, 2021 at 7:51 AM Nikhil Mohite wrote: > Hi Dave/ Team, > > As per the suggestions I have created a sample UI for change ownership of > shared servers before deleting the user(only for admin user). > [image: shared_server_change_ownsership.png] > The user list will contain all ad

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-31 Thread Nikhil Mohite
Hi Dave/ Team, As per the suggestions I have created a sample UI for change ownership of shared servers before deleting the user(only for admin user). [image: shared_server_change_ownsership.png] The user list will contain all admin users. (This alert will get display if the admin user has created

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-21 Thread Dave Page
Hi On Thu, Jan 21, 2021 at 10:33 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jan 21, 2021 at 3:24 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Reverted the commit. >> >> On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: >> >>> This seems like

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-21 Thread Nikhil Mohite
Hi Dave, On Thu, Jan 21, 2021 at 3:24 PM Akshay Joshi wrote: > Reverted the commit. > > On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: > >> This seems like a very bad idea. What if the user that has left was the >> user that setup 50 connections used by everyone else? >> >> Deleting those sha

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-21 Thread Akshay Joshi
Reverted the commit. On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: > This seems like a very bad idea. What if the user that has left was the > user that setup 50 connections used by everyone else? > > Deleting those shared entries is (I would guess) most likely *not* what > the majority of us

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-21 Thread Dave Page
This seems like a very bad idea. What if the user that has left was the user that setup 50 connections used by everyone else? Deleting those shared entries is (I would guess) most likely *not* what the majority of users would want, and the current behaviour is definitely safest. We should make th

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-21 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6143 > : Shared server entries not > getting deleted. > Added code to delete shared serve

[pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-20 Thread Nikhil Mohite
Hi Team, Please find the attached patch for RM-6143 : Shared server entries not getting deleted. Added code to delete shared server entries if the admin deletes the user from user management. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.*