Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Mon, Jun 14, 2021 at 3:43 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jun 14, 2021 at 8:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: >> >>> Hi >>> >>> On Mon, Jun 14, 20

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

On Mon, Jun 14, 2021 at 3:35 PM Akshay Joshi wrote: > Hi Dave > > On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have added the following commands for invalid com

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Dave, On Mon, Jun 14, 2021 at 8:05 PM Akshay Joshi wrote: > Hi Dave > > On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have added the following commands for i

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Dave On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > Hi > > On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I have added the following commands for invalid command check: >> >>1. \lo_import >>2. \lo_export >>3. \w o

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have added the following commands for invalid command check: > >1. \lo_import >2. \lo_export >3. \w or write >4. \o or \output >5. \g > > \qecho? \ev? I'm very concern

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Akshay, I have added the following commands for invalid command check: 1. \lo_import 2. \lo_export 3. \w or write 4. \o or \output 5. \g I am referring to the https://www.postgresql.org/docs/12/app-psql.html link for finding the commands. PFA patch V10. On Mon, Jun 14, 2021 a

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Mon, Jun 14, 2021 at 2:13 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch for psql, Updated invalid command logic > added 3 more commands in it. > 1. \copy or \COPY > 2. \e or \E > 3. \ef or \EF > Should they just be case insensitive

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Akshay, Please find the updated patch for psql, Updated invalid command logic added 3 more commands in it. 1. \copy or \COPY 2. \e or \E 3. \ef or \EF Now user can't execute these commands if allow shell commands is set to False. If required any changes please let me know. Regards, Nikhil Mo

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Thanks, the patch applied. On Mon, Jun 14, 2021 at 10:55 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > PFA patch v8 > > On Mon, Jun 14, 2021 at 10:25 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> Please find the updated patch for the PS

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Team, PFA patch v8 On Mon, Jun 14, 2021 at 10:25 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the updated patch for the PSQL tool, Added check if the > Windows version is not supporting the ConPty or WinPty disable the PSQL for > that version. (PSQL opt

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Team, Please find the updated patch for the PSQL tool, Added check if the Windows version is not supporting the ConPty or WinPty disable the PSQL for that version. (PSQL option will not visible to the user). I have raised the issue with "pywinpty" https://github.com/spyder-ide/pywinpty/issues/

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Fri, Jun 11, 2021 at 1:45 PM Fahar Abbas wrote: > Hi Dave, > > On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > >> >> >> On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas >> wrote: >> >>> Sure Dave, I will create a new VM with the latest iso. >>> >> >> Not the latest. 1809 please. And if tha

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Dave, On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > > > On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas > wrote: > >> Sure Dave, I will create a new VM with the latest iso. >> > > Not the latest. 1809 please. And if that doesn't work, 1909. We need to > understand exactly what versions work

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Sure Dave, I will update you soon. On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > > > On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas > wrote: > >> Sure Dave, I will create a new VM with the latest iso. >> > > Not the latest. 1809 please. And if that doesn't work, 1909. We need to > understand

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas wrote: > Sure Dave, I will create a new VM with the latest iso. > Not the latest. 1809 please. And if that doesn't work, 1909. We need to understand exactly what versions work and which don't. > Nikhil is not able to reproduce the issue on Windows 1

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Sure Dave, I will create a new VM with the latest iso. Nikhil is not able to reproduce the issue on Windows 10 with the latest version. So the issue is reproducible with older versions. Kind Regards, On Fri, Jun 11, 2021 at 1:28 PM Dave Page wrote: > > > On Fri, Jun 11, 2021 at 9:25 AM Fahar Abb

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

On Fri, Jun 11, 2021 at 9:25 AM Fahar Abbas wrote: > Windows 10 Enterprise 2016 LTSB. > Hmm, I assume that is version 1607. Can you test with 1809 please? And if that doesn't work, try 1909. > > On Fri, Jun 11, 2021 at 1:12 PM Dave Page wrote: > >> Hi >> >> On Fri, Jun 11, 2021 at 7:44 AM Fah

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Windows 10 Enterprise 2016 LTSB. On Fri, Jun 11, 2021 at 1:12 PM Dave Page wrote: > Hi > > On Fri, Jun 11, 2021 at 7:44 AM Fahar Abbas > wrote: > >> Hi, >> >> pgadmin4 is failing on following operating systems : >> Windows 2016 >> Windows 2012 >> Windows 07 >> Windows 2008R2 >> Windows 10 64 >>

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Fri, Jun 11, 2021 at 7:44 AM Fahar Abbas wrote: > Hi, > > pgadmin4 is failing on following operating systems : > Windows 2016 > Windows 2012 > Windows 07 > Windows 2008R2 > Windows 10 64 > What version of Windows 10? I *think* conpty was introduced in 1809. > > pgadmin4 is working fine

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi, pgadmin4 is failing on following operating systems : Windows 2016 Windows 2012 Windows 07 Windows 2008R2 Windows 10 64 pgadmin4 is working fine in following operating system: Windows 2019 On Thu, Jun 10, 2021 at 7:51 PM Dave Page wrote: > > > On Thu, Jun 10, 2021 at 2:22 PM Nikhil Mohite <

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Dave, On Thu, Jun 10, 2021 at 8:21 PM Dave Page wrote: > > > On Thu, Jun 10, 2021 at 2:22 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Jun 10, 2021 at 6:37 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jun 10, 2021 at 2:00 PM Nikhil Mohite < >>> nik

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

On Thu, Jun 10, 2021 at 2:22 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jun 10, 2021 at 6:37 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 10, 2021 at 2:00 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Thu, Jun 10, 20

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Wed, May 19, 2021 at 8:58 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave/ Team, > > On Tue, May 18, 2021 at 8:41 PM Dave Page wrote: > >> Hi >> >> On Tue, May 18, 2021 at 12:12 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> >> On M

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Dave/ Team, On Tue, May 18, 2021 at 8:41 PM Dave Page wrote: > Hi > > On Tue, May 18, 2021 at 12:12 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave/Team, > > > On Mon, May 17, 2021 at 6:47 PM Dave Page wrote: > >> Hi >> >> On Mon, May 17, 2021 at 11:01 AM Nikhil Mohite <

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Tue, May 18, 2021 at 12:12 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave/Team, > > > On Mon, May 17, 2021 at 6:47 PM Dave Page wrote: > >> Hi >> >> On Mon, May 17, 2021 at 11:01 AM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay/ Team, >>> >

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Mon, May 17, 2021 at 11:01 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay/ Team, > > Please find the attached updated patch for the psql tool. > Hmm, this version is also broken. There's a typo in editor_template.html on line 138 - it splits a string across two lines

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Tue, May 11, 2021 at 9:02 AM Akshay Joshi wrote: > Hi Nikhil > > Following are the review comments: > > *GUI specific*: > >- We need a panel icon for PSQL like query tool, we can also add that >on the browser tree toolbar. >- PSQL Tool menu should be visible for all the child n

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi Nikhil Following are the review comments: *GUI specific*: - We need a panel icon for PSQL like query tool, we can also add that on the browser tree toolbar. - PSQL Tool menu should be visible for all the child nodes of the database node. Follow the same as Query Tool. - PSQL ta

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

Hi On Mon, May 10, 2021 at 1:45 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-2341 > : Add Menu option for > starting PSQL. > 1. Added new Option PSQL Tool in Tools menu. > 2. Added the