Re: [pgAdmin][Patch] - RM #5940 - Add support for Oauth 2 authentication

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 12:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > On Mon, Jul 5, 2021 at 5:39 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Following are the revi

Re: [pgAdmin][Patch] - RM #5940 - Add support for Oauth 2 authentication

2021-07-05 Thread Akshay Joshi
Hi Khushboo Following are the review comments: *Scenario *: AUTHENTICATION_SOURCES = ['oauth2', 'internal'] - Don't set the OAUTH2_DISPLAY_NAME, Login button shows 'Login with None' which should be change. Maybe placeholder like . - Enter the email address and password. Click on the "Lo