Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 9:47 PM Rahul Shirsat wrote: > Hi Akshay, > > Please find the updated patch. > > On Tue, Jul 6, 2021 at 8:07 PM Akshay Joshi > wrote: > >> Hi Rahul >> >> On Tue, Jul 6, 2021 at 7:13 PM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >>

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-07-06 Thread Akshay Joshi
Hi Rahul On Tue, Jul 6, 2021 at 7:13 PM Rahul Shirsat wrote: > Hi Akshay, > > As discussed in the review meeting, following are the review comments > fixation: > > >- Label change - "Role operation" to "Reassign/Drop Own" > >IIRC, we have finalized "Operation" then from where

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-06-28 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 28, 2021 at 2:00 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > On Thu, Jun 24, 2021 at 2:32 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >>- The context m

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-06-24 Thread Akshay Joshi
Hi Rahul Following are the review comments: - The context menu should be renamed to 'Reassign/Drop Owned...' instead of 'Reassign/Drop role'. - Remove " role" from the dialog header. It should be "Reassign/Drop Owned - " - We have only two operations "Reassign and Drop", so instead