Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-07-05 Thread Akshay Joshi
Hi On Mon, Jul 5, 2021 at 1:40 PM Dave Page wrote: > > > On Fri, Jul 2, 2021 at 8:41 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> +1 for --no-fuzzy-matching for updating translations. >> >> On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> w

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-07-05 Thread Dave Page
On Fri, Jul 2, 2021 at 8:41 PM Rahul Shirsat wrote: > +1 for --no-fuzzy-matching for updating translations. > > On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 30,

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-07-02 Thread Rahul Shirsat
+1 for --no-fuzzy-matching for updating translations. On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 30,

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Khushboo Vashi
On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Please find the attached patch for resolving this issue wrt ab

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Dave Page
On Wed, Jun 30, 2021 at 2:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >>> rahul.shir.

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Aditya Toshniwal
Hi, On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Please find the attached patch for resolving this issue w

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Dave Page
Hi On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi All, >> >> Please find the attached patch for resolving this issue wrt above >> suggestion. >> > > Well that may fix the problem (and is a

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Dave Page
Hi On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi All, > > Please find the attached patch for resolving this issue wrt above > suggestion. > Well that may fix the problem (and is a reasonable change), however, I think it's important that we understand

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Rahul Shirsat
Hi All, Please find the attached patch for resolving this issue wrt above suggestion. Let me know if anyone has any queries. On Tue, Jun 29, 2021 at 9:20 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave / Aditya, > > For a time being, Let's make a call to gettext conditional

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Rahul Shirsat
Hi Dave / Aditya, For a time being, Let's make a call to gettext conditional instead of passing dynamic parameters for this scenario at least. With this, we won't be touching the *.po files and translations will do its task smoothly. I have already checked for the string with weird unprintable cha

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Dave Page
On Tue, Jun 29, 2021 at 2:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote: > >> >> >> On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Dave, >>> >>> Somehow, the new

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Aditya Toshniwal
Hi, On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote: > > > On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Dave, >> >> Somehow, the new text strings are added to PO with incorrect >> translations. That is causing the issue. >> Either they shoul

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Dave Page
On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Dave, > > Somehow, the new text strings are added to PO with incorrect translations. > That is causing the issue. > Either they should be empty or fixed. > Then the source problem should be fixed. There

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Aditya Toshniwal
Dave, Somehow, the new text strings are added to PO with incorrect translations. That is causing the issue. Either they should be empty or fixed. On Tue, Jun 29, 2021 at 7:01 PM Dave Page wrote: > Hi > > Please send the patch without updates to the po files. Those get updated > as part of the r

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Dave Page
Hi Please send the patch without updates to the po files. Those get updated as part of the release process. Thanks. On Tue, Jun 29, 2021 at 2:00 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Thanks Aditya for pointing out the issue. Please find the attached patch >

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Aditya Toshniwal
Hi Rahul, I did "make msg-extract" and "make msg-update" and looking at the PO files I think it is not updated correctly. For instance, the below message has msgstr without %s. I corrected it and the error was gone. #: pgadmin/browser/server_groups/servers/roles/static/js/role.js:766 #, fuzzy, py

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Dave Page
Hi On Tue, Jun 29, 2021 at 4:38 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > I feel gettext sometimes won't escape the characters as it should be. > > I now tried to escape those using some utils. > That won't work either. The string being passed to gettext() *must* be in the gett

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
I feel gettext sometimes won't escape the characters as it should be. I now tried to escape those using some utils. Please find the updated patch. On Mon, Jun 28, 2021 at 9:33 PM Dave Page wrote: > Hi > > On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote:

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Dave Page
Hi On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for fixation of jenkins failure. > That won't work - you can't include variables (or string building operations) in the first argument to gettext calls, as t

[patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for fixation of jenkins failure. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. jenkins_failure_fix.patch Description: Binary data