Re: [gpAdmin4][patch] query history updates

On Wed, Aug 9, 2017 at 3:37 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > The feature test for the QueryToolJourneyTest still fails on my Ubuntu > machine with/without this patch >

Re: [gpAdmin4][patch] query history updates

Hi, The patch looks good to me. The feature test for the QueryToolJourneyTest still fails on my Ubuntu machine with/without this patch , but works on Mac. Thanks, Khushboo On Wed, Au

Re: [gpAdmin4][patch] query history updates

Hi Khushboo! These are 2 separate patches. The failure of the feature test you're describing happens on Master even without this patch. The other patch fixes this, but is unrelated to this patch. Right now it applies cleanly on Master. If we rebase it here, we won't be able to apply it on master.

Re: [gpAdmin4][patch] query history updates

Hi Wenlin & Violet, On Tue, Aug 8, 2017 at 12:05 PM, Wenlin Zhang wrote: > Hi Khushboo, > > Thanks for your review. > > About the copy/paste function bug, we just found that this is an > existing bug in master. Except for the query History tab, this bug also > exist in the query data

Re: [gpAdmin4][patch] query history updates

Hi Khushboo, Thanks for your review. About the copy/paste function bug, we just found that this is an existing bug in master. Except for the query History tab, this bug also exist in the query data output . If you copy the data row in "Data Output" tab, it works fine, but the copy/past

Re: [gpAdmin4][patch] query history updates

Khushboo, On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang wrote: > Hi Hackers, > > Here is a patch for query tools history UX improvements: > >- Add copy button for query text >- Historical queries are binned by day > > Please review it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA:

[gpAdmin4][patch] query history updates

Hi Hackers, Here is a patch for query tools history UX improvements: - Add copy button for query text - Historical queries are binned by day Thanks, Sarah & Hao diff --git a/web/pgadmin/feature_tests/query_tool_journey_test.py b/web/pgadmin/feature_tests/query_tool_journey_test.py index 0