Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-16 Thread Akshay Joshi
Thanks patch applied. On Fri, Aug 16, 2019 at 7:31 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Akshay, > > On Fri, Aug 2, 2019 at 11:54 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Following test cases are missing: >> >>- Primar

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-15 Thread Murtuza Zabuawala
Hello Akshay, On Fri, Aug 2, 2019 at 11:54 AM Akshay Joshi wrote: > Hi Murtuza > > Following test cases are missing: > >- Primary Key column. > > There is no provision to set Primary key from Column dialog, This test case will be covered with Primary key constraint RE-SQL tests. > >- Va

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-01 Thread Akshay Joshi
Hi Murtuza Following test cases are missing: - Primary Key column. - Variable options. - Precision and Collation. - Identity column with 'GENERATED AS BY DEFAULT'. - ALTER column with identity values like CYCLE, minimum, maximum etc.. instead of updating comments in such test ca

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-01 Thread Akshay Joshi
Hi All I'll review this patch and give my review comments. On Wed, Jul 31, 2019 at 4:10 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add RE-SQL tests for Column node. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

[RM#4546] Add RE-SQL tests for Column node

2019-07-31 Thread Murtuza Zabuawala
Hi, PFA patch to add RE-SQL tests for Column node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company column_resql_tests.diff Description: Binary data