Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-06-07 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 7, 2021 at 5:08 PM Rahul Shirsat wrote: > Hi Akshay, > > Please find the updated patch below for your reference. I have added an > extra check for verifying the database rename. > Sorry for the inconvenience caused. > > On Tue, Jun 1, 2021 at 8:50 PM Akshay

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-06-07 Thread Rahul Shirsat
Hi Akshay, Please find the updated patch below for your reference. I have added an extra check for verifying the database rename. Sorry for the inconvenience caused. On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Sun, May 30, 2021 at 12:03 AM Rahul Shirsa

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-06-01 Thread Akshay Joshi
Thanks, the patch applied. On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > On Thu, May 27, 2021 at 12:19 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >>- Why you hav

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-05-26 Thread Akshay Joshi
Hi Rahul Following are the review comments: - Why you have changed the order of the toolbar button on the browser tree? It should not. - *sqleditor.js (check_db_name_change function)* - var declaration should be comma-separated instead of writing var, again and again. - Ad

[Patch][pgAdmin] RM4203 Rename Database by another user

2021-05-26 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of renaming the database by another user. A minor issue of navigation button alignment is also fixed in this patch. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4203.patch Description: Binary data