Hi
On Wed, Jun 26, 2019 at 8:20 AM Yosry Muhammad wrote:
> Hi,
>
> On Wed, Jun 26, 2019 at 1:01 PM Dave Page wrote:
>
>>
>>
- What else is missing from this patch to make it applicable ? I would
>> like to produce a release-ready patch if possible. If so, I can continue
>> working
On Wed, Jun 26, 2019 at 11:46 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> On Wed, Jun 26, 2019 at 10:35 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>>
>> My problem is not where to store the mogrified query, I can just replace
>>> the sql sent
Hi,
On Wed, Jun 26, 2019 at 1:01 PM Dave Page wrote:
>
>
>>> - What else is missing from this patch to make it applicable ? I would
> like to produce a release-ready patch if possible. If so, I can continue
> working on the project on following patches, I just want to know what is
>
Hi
On Tue, Jun 25, 2019 at 11:20 AM Yosry Muhammad wrote:
>
>
> On Tue, Jun 25, 2019 at 1:09 PM Dave Page wrote:
>
>>
>> - What else is missing from this patch to make it applicable ? I would
like to produce a release-ready patch if possible. If so, I can continue
working on the proje
Hi,
On Wed, Jun 26, 2019 at 10:35 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Yosry,
>
> On Tue, Jun 25, 2019 at 8:46 PM Yosry Muhammad wrote:
>
>> Hi,
>>
>>
>> OK. Yosry, How about storing the mogirfied query in the cookie/session
>>> when the query is executed and then
Hi Yosry,
On Tue, Jun 25, 2019 at 8:46 PM Yosry Muhammad wrote:
> Hi,
>
>
> OK. Yosry, How about storing the mogirfied query in the cookie/session
>> when the query is executed and then modifying query history storing logic
>> to use it when called ? This way you will not need to change any pars
On Tue, Jun 25, 2019 at 1:09 PM Dave Page wrote:
>
> - What else is missing from this patch to make it applicable ? I would
>>> like to produce a release-ready patch if possible. If so, I can continue
>>> working on the project on following patches, I just want to know what is
>>> the minimum amo
Hi,
OK. Yosry, How about storing the mogirfied query in the cookie/session when
> the query is executed and then modifying query history storing logic to use
> it when called ? This way you will not need to change any parsing when
> query history is displayed.
>
>> --
>>
>
My problem is not where
Hi,
On Tue, Jun 25, 2019 at 4:41 PM Dave Page wrote:
>
>
> On Tue, Jun 25, 2019 at 7:09 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached a patch file with the follow
On Tue, Jun 25, 2019 at 7:09 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad
> wrote:
>
>> Hi,
>>
>> Please find attached a patch file with the following updates (last patch
>> + updates) attached:
>> - Changed the color to
Hi
On Mon, Jun 24, 2019 at 7:03 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
>
> - What else is missing from this patch to make it applicable ? I would
>> like to produce a release-ready patch if possible. If so, I can continue
>> working on the project on following patches, I
Hi,
On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad wrote:
> Hi,
>
> Please find attached a patch file with the following updates (last patch +
> updates) attached:
> - Changed the color to $color-gray-lighter and added the shortcut for the
> new button.
> - Added a preferences option to enable/
Hi Yosry,
On Mon, Jun 24, 2019 at 11:08 AM Yosry Muhammad wrote:
> Hi all,
> Please find attached a patch with all the changes (from the beginning of
> the project). What I added in this patch:
>
> 1- Fixed #1 and #2 that Mr. Toshniwal pointed out in his code review.
> Still waiting for a reply
On Thu, Jun 20, 2019 at 7:49 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> [forked the mail chain for code review]
> Hi Yosry,
>
> On Wed, Jun 19, 2019 at 5:24 PM Dave Page wrote:
>
>>
>> Aditya; can you do a quick code review please? Bear in mind it's a work
>> in progress an
[forked the mail chain for code review]
Hi Yosry,
On Wed, Jun 19, 2019 at 5:24 PM Dave Page wrote:
> Hi
>
> On Wed, Jun 19, 2019 at 6:18 AM Yosry Muhammad wrote:
>
>>
>> Waiting for the icon, will set it up once it is ready.
>>
>
> It's underway :-)
>
>
>> I ran pep8 checks and JS tests on this
On Thu, Jun 20, 2019 at 2:20 AM Yosry Muhammad wrote:
> Hi there !
>
> On Wed, Jun 19, 2019 at 4:11 PM Dave Page wrote:
>
>>
>>> - We need to think about how data editing fits in with transaction
>>> control. Right now, it seems to happen entirely outside of it - for
>>> example, I tend to work
Hi there !
On Wed, Jun 19, 2019 at 4:11 PM Dave Page wrote:
>
>> - We need to think about how data editing fits in with transaction
>> control. Right now, it seems to happen entirely outside of it - for
>> example, I tend to work with auto commit turned off, so my connection sits
>> idle-in-tran
Hi
On Wed, Jun 19, 2019 at 2:47 PM Yosry Muhammad wrote:
> Hi,
>
>
> On Wed, Jun 19, 2019, 1:54 PM Dave Page wrote:
> .
>
> - We need to add a "do you want to continue" warning before actions like
> Execute or EXPLAIN are run, if there are unsaved changes in the grid.
>
> - I think we should ma
Hi,
On Wed, Jun 19, 2019, 1:54 PM Dave Page wrote:
.
- We need to add a "do you want to continue" warning before actions like
Execute or EXPLAIN are run, if there are unsaved changes in the grid.
- I think we should make the text in any cells that has been edited bold
until saved, so the user
Hi
On Wed, Jun 19, 2019 at 6:18 AM Yosry Muhammad wrote:
>
> Waiting for the icon, will set it up once it is ready.
>
It's underway :-)
> I ran pep8 checks and JS tests on this patch, however I could not run
> python tests due to a problem with chromedriver (working on it), please let
> me kn
Hi,
I have been working all day to try to make this patch applicable.
On Tue, Jun 18, 2019 at 3:05 PM Dave Page wrote:
> Hi
>
> [please keep the maililng list CC'd]
>
> On Mon, Jun 17, 2019 at 3:05 PM Yosry Muhammad wrote:
>
>>
>>> Do you want me to ask our design guy for an icon?
>>>
>>
>> Tha
Hi
[please keep the maililng list CC'd]
On Mon, Jun 17, 2019 at 3:05 PM Yosry Muhammad wrote:
>
>> Do you want me to ask our design guy for an icon?
>>
>
> That would be great to keep things clear and separated for the users.
>
I've asked Chethana (CC'd) to create one.
> Please find attached
Hi
On Sun, Jun 16, 2019 at 3:10 PM Yosry Muhammad wrote:
> This is a patch fixing a problem with the above patch that happened when:
> - primary key columns are renamed.
> - other columns are renamed to be like primary key columns.
>
> This problem happened mainly because the primary keys are id
This is a patch fixing a problem with the above patch that happened when:
- primary key columns are renamed.
- other columns are renamed to be like primary key columns.
This problem happened mainly because the primary keys are identified in the
front-end by their names. This can be handled in a be
Dear all,
This is my first patch of my GSoC project, query tool automatic mode
detection.
In this patch, the initial (basic) version of the project is implemented.
In this version, query resultsets are updatable if and only if:
- All the columns belong to a single table
- No duplicate columns are
25 matches
Mail list logo
