Re: [GSoC][New Feature] Editable and Read-only Columns

Hi Yosry, My guess is because selenium is running faster on our machine. Depends on machine. On Sat, Aug 24, 2019, 12:06 Yosry Muhammad wrote: > Hi Aditya, > > Thanks a lot. > > Do you have any idea why this problem never occurred on my machine by the > way? > > On Sat, Aug 24, 2019, 8:18 AM Ad

Re: [GSoC][New Feature] Editable and Read-only Columns

Makes sense. Thanks a lot for your help :) On Sat, Aug 24, 2019, 8:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > My guess is because selenium is running faster on our machine. Depends on > machine. > > On Sat, Aug 24, 2019, 12:06 Yosry Muhammad wrote: > >> Hi

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi Aditya, Thanks a lot. Do you have any idea why this problem never occurred on my machine by the way? On Sat, Aug 24, 2019, 8:18 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > It's failing for me as well. I debugged and found that, sometimes the grid > render

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi I've run it again 4 more times and it fails consistently for me. I'm running on macOS 10.14.5 with Chrome 76.0.3809.100. On Fri, Aug 23, 2019 at 3:17 PM Yosry Muhammad wrote: > Hi Dave, > > The tests pass on my device normally. I am using Python 3.6 on Ubuntu. I > have ran all tests using "m

Re: [GSoC][New Feature] Editable and Read-only Columns

Thanks. Unfortunately this is failing the tests: == ERROR: runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest) Tests the path through the query tool

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi Dave, The tests pass on my device normally. I am using Python 3.6 on Ubuntu. I have ran all tests using "make check" and they all succeeded. I also ran feature_tests/query_tool_journey_test.py multiple times on its own using "cd web && python regression/runtests.py --pkg feature_tests --modules

Re: [GSoC][New Feature] Editable and Read-only Columns

Except it now doesn't apply as the async connection/rendering patch was in the queue right ahead of it :-(. Can I get a rebased patch please? On Fri, Aug 23, 2019 at 11:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Excellent !! Looks good to me. > > On Fri, Aug 23, 2019 at

Re: [GSoC][New Feature] Editable and Read-only Columns

Excellent !! Looks good to me. On Fri, Aug 23, 2019 at 2:23 PM Yosry Muhammad wrote: > I updated the patch for backwards compatibility anyway. > > On Fri, Aug 23, 2019 at 10:45 AM Dave Page wrote: > >> >> >> On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad >> wrote: >> >>> Hi Aditya, >>> >>> On

Re: [GSoC][New Feature] Editable and Read-only Columns

I updated the patch for backwards compatibility anyway. On Fri, Aug 23, 2019 at 10:45 AM Dave Page wrote: > > > On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad wrote: > >> Hi Aditya, >> >> On Fri, Aug 23, 2019 at 7:33 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi

Re: [GSoC][New Feature] Editable and Read-only Columns

On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad wrote: > Hi Aditya, > > On Fri, Aug 23, 2019 at 7:33 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> The previously mentioned issues seems to be fixed. Below are few issues: >> 1) On Python 2.7, I get below erro

Re: [GSoC][New Feature] Editable and Read-only Columns

Aditya, can you review this please? Thanks. On Thu, Aug 15, 2019 at 8:01 PM Yosry Muhammad wrote: > Hi, hackers ! > > Please find attached a work-in-progress patch adding a new feature to the > Query Tool on top of updatable result-sets. > > This patch allows individual columns of an updatable

[GSoC][New Feature] Editable and Read-only Columns

Hi, hackers ! Please find attached a work-in-progress patch adding a new feature to the Query Tool on top of updatable result-sets. This patch allows individual columns of an updatable result-set to be editable or read-only. This allows for a wider variety of updatable result-sets, for example: