Re: [pgAdmin4][patch] update the alert style in the sub-navigation

t;> >>>>>>>>>> ​Hi, >>>>>>>>>> >>>>>>>>>> ​The updated patch looks good to me. >>>>>>>>>> >>>>>>>>>> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlea

Re: [pgAdmin4][patch] Fix feature tests failure

As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for those who would like to join) yesterday, these errors seem to occur only on her Ubuntu system. We have not replicated them on Mac. But they exist before this patch, also. We notice that copy/paste functionality is being tested

Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

Hi Surinder, This is great and useful. Looks good to me. Hope this can be committed ASAP. Thanks, Wenlin & Violet On Wed, Aug 2, 2017 at 9:41 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi All, > > This patch enables source maps in pgAdmin4 for development environment.

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

ks in > JS as xhr.responseText is empty. > However, it might be an existing issue. > > Thanks, > Surinder > > On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang wrote: > > Hi Ashesh, >> >> That's correct. This patch just changed alert style in t

Re: [gpAdmin4][patch] query history updates

Hi Khushboo, Thanks for your review. About the copy/paste function bug, we just found that this is an existing bug in master. Except for the query History tab, this bug also exist in the query data output . If you copy the data row in "Data Output" tab, it works fine, but the copy/past

[pgAdmin4][patch] Fix feature tests failure

Hi Hackers, This patch is about fixing the feature tests failure. Thanks, Wenlin, Violet & Hao diff --git a/web/pgadmin/feature_tests/query_tool_journey_test.py b/web/pgadmin/feature_tests/query_tool_journey_test.py index 0795028c..dcab7241 100644 --- a/web/pgadmin/feature_tests/query_tool_journ

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

/www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > > On Mon, Aug 7, 2017 at 8:11 AM, Sarah McAlear wrote: > >> Hi hackers, >> >> Could you please review this patch? >> >> Thanks

[pgAdmin4][patch] update the alert style in the sub-navigation

Hi Hackers, This patch changes the alert style in the sub-navigation to match style guide. Thanks, Wenlin, Shirley & Sarah diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js index 45939b00..23d1d50e 100644 --- a/web/pgadmin/browser/static/js/browser.