Re: pgagent unicode support

2021-02-24 Thread Sergey Burladyan
Neel Patel writes: > Thanks for the review. Please find the attached updated patch. > Do review it and let me know in case of any comments. Looks good, thanks! -- Sergey Burladyan

Re: pgagent unicode support

2021-02-24 Thread Sergey Burladyan
Sergey Burladyan writes: > Maybe it should look something like this: > +wcstombs_s(&charsConverted, mbs, mb_len + 1, wchar_str, mb_len); Ah, and we missed check for error. Something like this, maybe: +#ifdef __WIN32__ +size_t charsConverted = 0; +if (

Re: pgagent unicode support

2021-02-24 Thread Sergey Burladyan
d4b0d3d 100644 --- a/unix.cpp +++ b/unix.cpp @@ -155,6 +155,8 @@ static void daemonize(void) int main(int argc, char **argv) { + setlocale(LC_ALL, ""); + std::wstring executable; executable.assign(CharToWString(argv[0])); -- Sergey Burladyan

pgagent unicode support

2021-02-05 Thread Sergey Burladyan
cter 8 2021-02-05 23:19:05 UTC [15600-2] postgres@postgres STATEMENT: select ' Please see attached patch. I only test it on GNU/Linux and can't test it on Windows, sorry. -- Sergey Burladyan commit b9cf098a4d0df53b7b623a0de844fce834bf7be1 (HEAD -> x5) Author: Sergey