Re: Code Folding in Code Mirror

Ok, it does work for the cases defined. We misunderstood how it works. Still, could we enable this everywhere? What is the reason not to? Thanks, Bing & Sarah On Tue, Aug 15, 2017 at 5:00 PM, Sarah McAlear wrote: > Hi Hackers! > > We are working on unifying the CodeMirror s

Code Folding in Code Mirror

Hi Hackers! We are working on unifying the CodeMirror stuff into one location. While looking at this we noticed that while there is logic for code folding, it doesn't seem to be working. Does it work for everyone else? We also started to wonder if there is a specific reason that code folding shoul

Re: [pgAdmin4][RM2586] Cleanup feature test

> Harshal > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Aug 7, 2017 at 8:55 AM, Sarah McAlear wrote: > >> Hi Harshal! >> >> There are a few fil

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

his patch, the alert style of "Database >>>> connected" message is changed. >>>> Can you please look into this? >>>> >>>> Thanks, >>>> Surinder >>>> >>>> On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar < >>>&g

[pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi Hackers! This patch applies to RM 2644 . It fixes the styling of the checkmark area. Thanks! Sarah diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss index 8344956b..2c1e1d49 100644 --- a

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

h On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear wrote: > Hi Surinder! > > I am not able to see anything different from what I see on Master with or > without the patch applied. I tried adjusting the preferences. I did update > the dashboard.js to instantiate a new object, great i

Re: [pgadmin4] unable to pull remote

s so it will work, but you both miss out on the security > and will get lower performance because it will be more requests. > > //Magnus > > > On Wed, Aug 9, 2017 at 11:30 AM, Sarah McAlear > wrote: > >> Great, thank you! >> >> On Wed, Aug 9, 2017 at 5:26

Re: [pgadmin4] unable to pull remote

it.postgresql.org/git/pgadmin4.git > <http://git.postgresql.org/git/pgadmin4.git>* > > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Aug 9, 2017 at 2:3

[pgadmin4] unable to pull remote

Hi Hackers! We noticed that as of some time today (it worked this morning) we are unable to pull git.postgresql.org/git/pgadmin4.git. Is this a known issue? Our other repos seem to work fine still. Thanks, Sarah

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

n, Aug 7, 2017 at 10:40 AM, Wenlin Zhang wrote: >>> >>> Hi Ashesh, >>>> >>>> That's correct. This patch just changed alert style in the 'tabs', >>>> such as Dependency and Dependents. >>>> >>>>

[pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi Hackers! This patch enables Greenplum users to see the same charts on the dashboard as postgres users. It also adds some additional information to the DDL that is Greenplum specific and necessary to create a new table. Thanks! Sarah diff --git a/web/pgadmin/browser/server_groups/servers/datab

Re: [pgAdmin4][patch] Fix feature tests failure

Hi Hackers! Could someone review this patch, please? Thanks so much! Sarah On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch is about fixing the feature tests failure. > > Thanks, > Wenlin, Violet & Hao >

Re: [gpAdmin4][patch] query history updates

Hi Khushboo! These are 2 separate patches. The failure of the feature test you're describing happens on Master even without this patch. The other patch fixes this, but is unrelated to this patch. Right now it applies cleanly on Master. If we rebase it here, we won't be able to apply it on master.

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

analyze buttons, previous messages from Message >>> tab are not getting clear but instead new messages are getting appended to >>> previous ones. >>> >>> And could you please correct a typo introduced by Me from file >>> ../templates/datagrid/index.html, &#x

Re: [pgAdmin4][RM2586] Cleanup feature test

Hi Harshal! There are a few files in which there are leftover imports that are not needed anymore: - PGDataypeFeatureTest - PgadminPage - CheckForXssFeatureTest - CheckDebuggerForXssFeatureTest We also noticed that there were quite a few time.sleep functions that were removed. This

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi hackers, Could you please review this patch? Thanks Wenlin and Sarah On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch changes the alert style in the sub-navigation to match style > guide. > > Thanks, > Wenlin, Shirley & Sarah > > >

Re: Discussion on improving alertify notifications logic

Hi Akshay! That seems like a good idea. When we're using the extended pgadmin.alerrtify in the codebase it would be beneficial to call it pgAdminAlertify or something similar so that it is clear that it isn't only the alertify library, but it's been extended. Rob & Sarah On Thu, Jul 27, 2017 at

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi! We looked at the patch and realized that the function to check if an element is not clickable because it's out of view was using an incorrect assertion. We changed it and created a small patch. We also realized that on the current master the yarn.lock is causing changes when running the app. I

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hello, Attached is a refactor that extracts the keyAction function in the sqlEditor and placed it into a keyboard_shortcuts file. The extracted code is unit tested. I did not look at the feature tests. We are planning on diving into it a bit more but maybe not immediately. Up next we will be pull

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Surinder & Murtuza! We are actually working on that right now. We should be sending a patch soon. Thanks! Shruti & Sarah On Thu, Jul 20, 2017 at 7:52 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Can the code related to Menu KeyEvents be moved out into a sepa

Re: [PATCH] Persist opened nodes in tree

Hello, In order to save everything in the backend sqlite database, maybe a jQuery plugin needs to be developed that has the same interface as jStorage and that will do Ajax calls instead of using the Local Storage. The only caveat for this is that it needs to be registered in window. $.jStorage in

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

Hello Hackers, We regenerated the add-readme.diff to include additions to .gitignore to ignore the compiled python files and the compiled CSS files and we added to yarn.lock file. Thanks, Joao & Sarah On Fri, Jul 14, 2017 at 10:24 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wro

[pgadmin4][patch] fix history panel on ie11

Hi Hackers! This patch fixes the layout issues on IE11. There is a known issue on react-split-pane that requires a previous version of bowser in order to render correctly on IE11. We had to downgrade the version of bowser to 1.6.1 until the relevant pull request to react-split-pane has been accept

[pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

Hi Hackers! Attached is a minor patch that enables pretty html output of our karma test results. While running yarn test:karma, visit localhost:9876/debug.html to see test output. Thanks, Matt and Sarah diff --git a/web/karma.conf.js b/web/karma.conf.js index 39697ca7..e9b0e062 100644 --- a/web/k

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hello, > *​Things to discuss:* > > How to differentiate between a static and template JS > ​​ > . > What is the advantage of webpacking templated JS? It seems as though this creates a system in which the bundled dependencies have to refer back to the backend to load the templates. If there is a

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello! Thank you for committing the patch! We are currently looking into CEF ( https://bitbucket.org/chromiumembedded/cef) as an alternative to QTWebKit. So far it looks promising. It works on all platforms. It is the base for Google Chrome, so it should be maintained for some time to come. Versi