[pgadmin-org/pgadmin4] cd8420: Fix system stat dashboard UI issues.

2023-10-10 Thread Sahil Harpal
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: cd842001351063da71cd22552eecbb9546b7a91a https://github.com/pgadmin-org/pgadmin4/commit/cd842001351063da71cd22552eecbb9546b7a91a Author: Sahil Harpal <56965873+sahil1...@users.noreply.github.

[pgadmin-org/pgadmin4] 16c95d: GUI representation of the system's activity using ...

2023-10-02 Thread Sahil Harpal
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 16c95d21a73ac4b8b1851c9e8b7099c30a53e753 https://github.com/pgadmin-org/pgadmin4/commit/16c95d21a73ac4b8b1851c9e8b7099c30a53e753 Author: Sahil Harpal <56965873+sahil1...@users.noreply.github.

Re: Pgadmin4 System Stats Extension Design

2023-09-15 Thread Sahil Harpal
Hi Khushboo, Could you please suggest labels for the tables in the Memory and CPU tabs. Also, I'm not able to reproduce the alignment issue that you have mentioned, but I have added a fix to by setting width to 100% maybe it would work. Thank you, Sahil

Re: Pgadmin4 System Stats Extension Design

2023-09-12 Thread Sahil Harpal
Hello Aditya, On Fri, 8 Sept 2023 at 09:04, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > Your PR is showing 135 file changes and a lot of commits which shouldn't > have appeared on your PR. > It is very difficult to identify your changes. Can you please check once?

Re: Pgadmin4 System Stats Extension Design

2023-08-27 Thread Sahil Harpal
nk you, Sahil On Sun, 27 Aug 2023 at 07:13, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Sat, 26 Aug 2023, 11:36 Sahil Harpal, > wrote: > >> Hi Khushboo, >> >> On Mon, 21 Aug 2023 at 10:03, Khushboo Vashi < >> khushboo.va...@ente

Re: Pgadmin4 System Stats Extension Design

2023-08-25 Thread Sahil Harpal
Hi Khushboo, On Mon, 21 Aug 2023 at 10:03, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Sahil, once the issues get resolved, please raise the PR and we will do > the final review there. > Could you please tell me to which branch I should raise the PR? Also, should I remove the code

Re: Pgadmin4 System Stats Extension Design

2023-08-25 Thread Sahil Harpal
I have added the idea of array initialization for the 'Process & handle count' chart. Let me know if similar can be used for all the streaming charts to resolve the graph shifting issue. On Fri, 25 Aug 2023 at 13:34, Sahil Harpal wrote: > Hi Aditya, > On Fri, 25 Aug 2

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi Aditya, On Fri, 25 Aug 2023 at 12:06, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal > wrote: > >> Hi Aditya, >> On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < >> aditya.to

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi Aditya, On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal > wrote: > >> Hi, >> Can we include total space stats (left pie chart) in the same bar chart? >>

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
On Sat, 19 Aug 2023 at 16:20, Sahil Harpal wrote: > On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >>- Sometimes graphs start from left and then shift to right. This >>issue I have reported in my initial rev

Re: Pgadmin4 System Stats Extension Design

2023-08-24 Thread Sahil Harpal
Hi, Can we include total space stats (left pie chart) in the same bar chart? or would it be better if we keep it separate? [image: image.png]

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
ere <https://pgsnake.blogspot.com/2020/06/systemstats-extension-for-postgresql.html>), it's returning paths for mount_point and null for drive_letter. On Tue, 22 Aug 2023 at 23:34, Sahil Harpal wrote: > On Mon, 21 Aug 2023 at 09:59, Khushboo Vashi < > khushboo.va...@enterprisedb.c

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
On Mon, 21 Aug 2023 at 09:59, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Sat, Aug 19, 2023 at 4:21 PM Sahil Harpal > wrote: > >> On Thu, 10 Aug 2023 at 00:37, Sahil Harpal >> wrote: >> >>> Pending Work: >>> >

Re: Pgadmin4 System Stats Extension Design

2023-08-22 Thread Sahil Harpal
On Tue, 22 Aug 2023 at 16:02, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Sahil, > > On Tue, Aug 22, 2023 at 1:19 PM Sahil Harpal > wrote: > >> Hello Khushboo, >> >> Thank you for sharing this with me. As you can see, towards the end, wh

Re: Pgadmin4 System Stats Extension Design

2023-08-20 Thread Sahil Harpal
pgAdmin4-cursor-rec.mp4 <https://drive.google.com/file/d/19_Fw-hvZue4_1tTED9INss33eZcfdIEd/view?usp=drive_web> Hi Khushboo, On Mon, 21 Aug 2023 at 09:55, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Fri, Aug 18, 2023 at 10:08 AM Sahil Harpal > wrote: >

Re: Pgadmin4 System Stats Extension Design

2023-08-19 Thread Sahil Harpal
On Thu, 10 Aug 2023 at 00:37, Sahil Harpal wrote: > Pending Work: > >1. Process information - > - Issue: The pg_sys_process_info() query takes much longer (more > than 2 mins) to execute and prevents the updation of other graphs and > tables. >

Re: Pgadmin4 System Stats Extension Design

2023-08-19 Thread Sahil Harpal
t a priority. > Or try the solution below? On Sun, 6 Aug 2023 at 13:21, Sahil Harpal wrote: > I've tried one more approach here. If our data array is full, this graph > shifting won't happen. So, if we initialize our data list with null values, > there won't be any vis

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > >- The Tooltip for graph points remains on the page. Please refer to >the below screenshot. > > Is this happening simply by moving the cursor within the graph area or when resizing the screen? For me,

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
Hi Khushboo, I have made the necessary changes and pushed them to the same repository. Let me know if that resolves this null value issue. Thank you, Sahil >

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 15:08, Dave Page wrote: > On Thu, 17 Aug 2023 at 10:36, Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 14:53, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal >

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 14:53, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Thu, Aug 17, 2023 at 2:50 PM Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>

Re: Pgadmin4 System Stats Extension Design

2023-08-17 Thread Sahil Harpal
On Thu, 17 Aug 2023 at 14:39, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Sample data of my system to fix this issue: > >1. process331: > 1. memory_bytes:null > 2. memory_usage:null > 3. name:"QuickLookUIServi" > 4. pid:938 > 5. row_number:331 > > O

Re: Pgadmin4 System Stats Extension Design

2023-08-16 Thread Sahil Harpal
Hi Khushboo, On Thu, 17 Aug 2023 at 10:39, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Can you please fix the below JS error ? Due to this CPU and Memory tabs > are not working. > [image: Screenshot 2023-08-17 at 10.35.34 AM.png] > For me, it's working properly. I think in your ca

Re: Pgadmin4 System Stats Extension Design

2023-08-16 Thread Sahil Harpal
itespace, but > there are no trailing whitespaces. The 'yarn run bundle:dev' command also > does not give any prompt for this. Could you please suggest what to do? > > > On Wed, 16 Aug 2023 at 11:08, Sahil Harpal > wrote: > >> Could you please try this attached patch. >> >

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
n bundle:dev' command also does not give any prompt for this. Could you please suggest what to do? On Wed, 16 Aug 2023 at 11:08, Sahil Harpal wrote: > Could you please try this attached patch. >

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
Could you please try this attached patch. SS_WIP.patch Description: Binary data

Re: Pgadmin4 System Stats Extension Design

2023-08-15 Thread Sahil Harpal
23 at 00:37, Sahil Harpal wrote: > Hi all, > > I have attached the updated patch with recent changes. > > New changes: > >1. Displayed the appropriate message If the System Stat extension does >not exist. >2. Provided option to configure refresh rates for

Re: Pgadmin4 System Stats Extension Design

2023-08-09 Thread Sahil Harpal
Hi all, I have attached the updated patch with recent changes. New changes: 1. Displayed the appropriate message If the System Stat extension does not exist. 2. Provided option to configure refresh rates for the API calls (Preferences settings > Dashboards > Refresh rates). 3. Add

Re: Pgadmin4 System Stats Extension Design

2023-08-07 Thread Sahil Harpal
Hi Aditya, On Mon, 7 Aug 2023 at 11:01, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > I would suggest changing the behaviour in StreamingChart so that it can be > used at other places. If you want to reverse it then you can still do it. I > had achieved reverse directi

Re: Pgadmin4 System Stats Extension Design

2023-08-06 Thread Sahil Harpal
Hi Aditya, On Thu, 3 Aug 2023 at 09:32, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote > Because it is the default behaviour of streaming. You can add a prop > reverse=true to StreamingChart and change the code ret.reverse(); based > on condition. > So basically, you are suggesting to

Re: Pgadmin4 System Stats Extension Design

2023-08-02 Thread Sahil Harpal
Hi Khushboo, On Thu, 27 Jul 2023 at 16:26, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > You have made different files tab-wise; it would be more manageable if you > could put them under a subfolder OR start a name with system_state or > something like that. > On Thu, Jul 27, 2023 at

Re: Pgadmin4 System Stats Extension Design

2023-07-27 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 15:58, Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > [image: image.gif] > >> It fails while applying. Can you please rebase your patch and send it? >> > > Could you ple

Re: Pgadmin4 System Stats Extension Design

2023-07-25 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 16:39, Dave Page wrote: > OK, so F and G are not being shown in the query results (or more > correctly, they are there, but the drive letter is showing as NULL?). If > so, that seems like a bug in the extension. > Yeah, it's showing NULL for the F and G drives. Can anyone p

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 15:34, Dave Page wrote: > On your system, what are the volumes without letters etc? If they're > things like swap/pagefile, recovery partition etc, then they can probably > be omitted (e.g. SELECT ... WHERE mount_point IS NOT NULL OR drive_letter > IS NOT NULL). > On my s

Re: Pgadmin4 System Stats Extension Design

2023-07-24 Thread Sahil Harpal
On Mon, 24 Jul 2023 at 10:57, Ashesh Vashi wrote: > Please share the exact output of the query to get any suggestions. > The following is the output returned by the query: mount_point | file_system | drive_letter | drive_type | file_system_type | > total_space | used_space | free_space | t

Re: Pgadmin4 System Stats Extension Design

2023-07-20 Thread Sahil Harpal
On Wed, Jul 12, 2023, 3:58 PM Sahil Harpal wrote: > > Could you please try the attached patch. > Could you please confirm whether it's working or not? Also is there anything that we can improve in this patch. Thanks, Sahil >

Re: Pgadmin4 System Stats Extension Design

2023-07-20 Thread Sahil Harpal
On Wed, Jul 12, 2023, 4:33 PM Ashesh Vashi wrote: > If it is an extension issue, you may want to create an issue in its github > repo with reproduction steps, current & expected behaviour. > I think the issue is mostly with windows systems can anyone please confirm whether the pg_sys_process_inf

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 10:26, Ashesh Vashi wrote: > On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal > wrote: > >> On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal >> wrote: >> >>> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi < >>> ashesh.va...@ente

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Sahil Harpal
On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > It fails while applying. Can you please rebase your patch and send it? > Could you please try the attached patch. WIP.patch Description: Binary data

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Sahil Harpal
On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal wrote: > On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi > wrote: > >> Try preloading the extension in the PostgreSQL server. >> e.g. Add this extension in the 'shared_preload_libraries' in >> postgresql.conf. &g

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Sahil Harpal
On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi wrote: > Try preloading the extension in the PostgreSQL server. > e.g. Add this extension in the 'shared_preload_libraries' in > postgresql.conf. > > Reference: https://pgpedia.info/s/shared_preload_libraries.html > Thank you, Ashesh! I will try this an

Re: Pgadmin4 System Stats Extension Design

2023-06-26 Thread Sahil Harpal
On Sun, Jun 25, 2023, 3:02 AM Dave Page wrote: > Can you add a different scale on the right hand side? I haven’t > familiarised myself with the library we’re using now, but others I’ve used > can do that. > Yeah sure. I think we can do this by passing few additional configuration options. I'll l

Re: Pgadmin4 System Stats Extension Design

2023-06-24 Thread Sahil Harpal
I tried combining the process and handle count in a single graph. But as you can see in the attached image, insights are not properly visible since the difference between the values is too large. Even when the process count is 320, without tooltips, it appears as zero. Can we draw separate graphs f

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Sahil Harpal
On Fri, 16 Jun 2023 at 14:15, Sahil Harpal wrote: > [image: image.gif] > >> I think combining R/W is fine, as long as it uses two scales in case the >> values are wildly different (which is likely). > > > So should I combine all the parameters (Total read/write ope

Re: Pgadmin4 System Stats Extension Design

2023-06-17 Thread Sahil Harpal
2023 at 15:22, Dave Page wrote: > > > On Thu, 15 Jun 2023 at 09:55, Sahil Harpal > wrote: > >> Hi Aditya, >> >> Thank you for pointing this out. It would also be more convenient for >> users to navigate to specific statistics easily. >> >> So

Re: Pgadmin4 System Stats Extension Design

2023-06-16 Thread Sahil Harpal
etc., per disk OR Sahil doing a different graph for each >> parameter for all the disks? >> > > I think combining R/W is fine, as long as it uses two scales in case the > values are wildly different (which is likely). > > >> >> On Thu, Jun 15, 2023

Re: Pgadmin4 System Stats Extension Design

2023-06-15 Thread Sahil Harpal
anager). > It will reduce the network calls, cluttering and improve DOM performance. > > > On Thu, Jun 15, 2023 at 11:08 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Sahil >> >> On Thu, Jun 15, 2023 at 1:42 AM Sahil Harpal >> wrote: &g