Re: pgagent unicode support

Hi Dave/Ashesh, Do you have any further comments ? Thanks, Neel Patel On Wed, Feb 24, 2021 at 8:14 PM Sergey Burladyan wrote: > Neel Patel writes: > > > Thanks for the review. Please find the attached updated patch. > > Do review it and let me know in case of any commen

Re: pgagent unicode support

Hi Sergey, Thanks for the review. Please find the attached updated patch. Do review it and let me know in case of any comments. Thanks, Neel Patel On Wed, Feb 24, 2021 at 5:12 PM Sergey Burladyan wrote: > Sergey Burladyan writes: > > > Maybe it should look somethi

Re: pgagent unicode support

Hi Sergey, Do you have any comments for this updated patch ? Let us know ASAP so that we can commit it. Thanks, Neel Patel On Thu, Feb 18, 2021 at 5:12 PM Neel Patel wrote: > Hi Sergey, > > Thank you for the patch. It looks good to me except below. > > We have modified the pa

Re: pgagent unicode support

Hi Sergey, Thank you for the patch. It looks good to me except below. We have modified the patch as we fixed the memory leak ( review comment given by Ashesh ) and also fixed the compilation warnings. Can you please review and let us know ? Thanks, Neel Patel On Mon, Feb 15, 2021 at 6:15 PM

Re: pgagent unicode support

Thanks Sergey for the patch. Sure Dave. There is some compilation warning in linux, I will fix those and test pgAgent in windows and update the thread. On Mon, Feb 8, 2021 at 2:55 PM Dave Page wrote: > Hi > > On Sat, Feb 6, 2021 at 5:00 AM Sergey Burladyan > wrote: > >> Currently pgagent doesn

Re: pgAgent build warnings on Fedora 32

[100%] Built target pgagent ### On Wed, Sep 9, 2020 at 7:39 PM Devrim Gündüz wrote: > > Hi Neel, > > On Fri, 2020-04-24 at 18:15 +0530, Neel Patel wrote: > > I will look into it. > > Any updates? > > Cheers, > -- >

Re: Raise an exception under Python < 3.4

Hi, On Wed, Apr 29, 2020 at 2:52 PM Dave Page wrote: > Hi > > On Wed, Apr 29, 2020 at 10:13 AM Neel Patel > wrote: > >> Hi Dave, >> >> Patch looks good to me except one condition as we do support from Python >> 3.4 onwards. I have modified that c

Re: Raise an exception under Python < 3.4

Hi Dave, Patch looks good to me except one condition as we do support from Python 3.4 onwards. I have modified that condition and attached the updated patch. I have also removed the other references of Python2. Attached is the patch. Do review it and let me know for comments. Thanks, Neel Patel

Re: Remove Python 2 support from the desktop runtime

Hi Dave, I reviewed and tested and it looks good to me. Thanks, Neel Patel On Tue, Apr 28, 2020 at 1:32 PM Dave Page wrote: > Apparently, yes :-( > > On Mon, Apr 27, 2020 at 9:15 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Did you forget to atta

Re: pgAgent build warnings on Fedora 32

I will look into it. On Fri, Apr 24, 2020 at 5:51 PM Devrim Gündüz wrote: > > Hi, > > pgAgent throws the warnings below while compiling it on Fedora 32, which > uses GCC 10. Can you please take a look? > > Thanks! Devrim > > === > /usr/bin/make > DESTDIR=/var/lib/pgs

Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

Hi Dave, On Fri, Apr 24, 2020 at 3:00 PM Dave Page wrote: > > > On Fri, Apr 24, 2020 at 10:23 AM Vik Fearing > wrote: > >> >> >> On Fri, Apr 24, 2020 at 11:10 AM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Apr 23, 2020 at 12:

[pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

rsion. Do review it and let me know for comments. Thanks, Neel Patel pgagent_4_2.patch Description: Binary data

Re: [Patch][pgAdmin4]: Fix pgagent issues

Hi Akshay, Please find the attached update patch with the fix. Also fixed the Roles resql test cases as it was failing due to timezone change. Thanks, Neel Patel On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi wrote: > Hi Neel > > RESQL test cases are failing on my machine due to

[Patch][pgAdmin4]: Fix pgagent issues

and schedule if disabled from browser tree, same as pgagent job - Fixes #4636 - Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623 Do review it and let me know for comments. Thanks, Neel Patel diff --git a/docs/en_US/release_notes_4_21.rst b/docs/en_US/release_notes_4_21.rst index

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi, I think we should remove the type cast from query during update and whatever error is thrown should be shown to UI as per scenario 3. Thanks, Neel Patel On Wed, Apr 15, 2020 at 3:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 15, 2020 at

Re: Proposal: Drop support for Internet Explorer

Hi Dave, Looks like patch is missing in attachment. Thanks, Neel Patel On Tue 14 Apr, 2020, 6:53 PM Dave Page, wrote: > Here's an updated patch that gives a slightly different message if the > browser is unknown vs. unsupported/deprecated. As with the previous patch, > th

[Patch]: Typo in 'test_config.json.in' file

Hi, Fix the typo in the test configuration json file while running the test cases. Currently if someone uses the latest file to run the test cases, it will fail to run. Please find the attached patch. Thanks, Neel Patel test_config.patch Description: Binary data

[pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration

Hi, Please find an attached patch to fix the issue in the configuration window in runtime where control where not auto resize and visible when the user resizes the dialog. Do review it and let me know for comments. Thanks, Neel Patel diff --git a/runtime/ConfigWindow.ui b/runtime

Re: PgAgent leap year problem

Hi Ashesh, I have reviewed it and looks good. I have updated the sql version in header of each sql file. Thanks, Neel Patel On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi wrote: > On Wed, Mar 4, 2020 at 10:53 AM Neel Patel > wrote: > >> Hi Mehmet, >> >> It was a bu

Re: PgAgent leap year problem

Hi Mehmet, It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine. Dave/Ashesh:- Can we commit this patch ? Thanks, Neel Patel On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ wrote: > Hi, > > Scheduled tasks set as the la

Re: RM5049 Patch

Patch only covers removal of the code and change in "coveragerc.in". I guess you missed to add the new files in the patch. Can you please verify ? Thanks, Neel Patel On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Pleas

Re: RM 4463 - MSQL test cases for domain node

Hi, Please find attached updated patch. I have tested with PG 9.4, PG 10 & EPAS 10. Do review it and let me know in case of any failures. Thanks, Neel Patel On Fri, Aug 23, 2019 at 1:52 PM Dave Page wrote: > Hi > > On Wed, Aug 21, 2019 at 8:58 AM Neel Patel > wrote: >

Re: RM 4463 - RESQL test cases for domain node

ues/4644>. I am sending separate patch for the same. Thanks, Neel Patel On Fri, Jul 12, 2019 at 7:10 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jul 12, 2019 at 12:31 PM Neel Patel > wrote: > >> Hi, >> >> Please find attached patch for reverse enginee

RM 4463 - MSQL test cases for domain node

tps://redmine.postgresql.org/issues/4644>. I have sent separate patch for the same. Thanks, Neel Patel RM_4463_v2.patch Description: Binary data

[Patch]: RM-4644 - Length and Precision control for domain node

Hi, Please find attached patch to fix RM-4644 - Length and Precision control should enable/disable based on change in data type. Do review it and let me know for comment. Thanks, Neel Patel RM-4644.patch Description: Binary data

RM 4463 - RESQL test cases for domain node

Hi, Please find attached patch for reverse engineering test cases for domain node ( RM #4463 ) Do review it and let me know for comments. Thanks, Neel Patel RM_4463.patch Description: Binary data

Re: Minor patch to fix reggression of select2 option

Hi Dave, RM is 4218 <https://redmine.postgresql.org/issues/4218> Thanks, Neel Patel On Tue, Apr 30, 2019 at 1:25 PM Dave Page wrote: > Hi > > What's the RM for this? > > On Tue, Apr 30, 2019 at 8:00 AM Neel Patel > wrote: > >> Hi Team, >> >>

Minor patch to fix reggression of select2 option

Hi Team, Please find attached patch to fix the issue where we should properly assigned 'dropdownParent' select2 options. This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717 Do review it and let us know for comments. Thanks, Neel Patel select2_options.patch D

[Patch]: Minor change in dependency_inventory file to generate library file

Hi, Please find attached patch to handle JSON object properly to avoid error like "the JSON object must be str, not 'bytes'" while generating library.txt file. Verified with both python2 and python3. Do review it and let me know for comments. Thanks, Neel Patel -- <htt

Re: pgAdmin 3.0 builds

Hi, On Tue, Apr 10, 2018 at 5:44 PM, Dave Page wrote: > > > On Tue, Apr 10, 2018 at 1:02 PM, Fahar Abbas > wrote: > >> Yes Akshay is not able to reproduce this issue on VMWare Fusion 6.0.6 >> while Khushboo is facing same issue on Windows 07 64. >> >> I am using VMware Fusion 10 version and fac

Re: Building releases...

On Mon, Apr 9, 2018 at 6:51 PM, Dave Page wrote: > > > On Mon, Apr 9, 2018 at 2:20 PM, Neel Patel > wrote: > >> Hi Dave, >> >> On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>&

Re: Building releases...

Hi Dave, On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Apr 9, 2018 at 6:19 PM, Dave Page wrote: > >> Oh yeah - I forgot to mention that running it in PyCharms seems to work. >> The issue comes when using the runtime from what I can see (ev

Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios

Thanks, RM#3249 created for the same. Regards, Neel Patel On Thu, Apr 5, 2018 at 11:27 AM, Akshay Joshi wrote: > Hi Neel > > This issue is not due to the above fix, if you can see the error it is > showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);&quo

Re: [pgAdmin4]: Fix for RM #3248

Hi, Please find updated patch after fixing the comments. Review it and let me know for comments. Thanks, Neel Patel On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel wrote: > Thanks Murtuza & Khushboo. > I will send updated patch. > > Thanks, > Neel Patel > > On Thu

Re: [pgAdmin4]: Fix for RM #3248

Thanks Murtuza & Khushboo. I will send updated patch. Thanks, Neel Patel On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Neel, > > Add below code to the top (around line no 8) in > alertify.pgadmin.defaults.js file

[pgAdmin4]: Fix for RM #3248

Hi, Please find attached patch for the fix of RM #3248 - we have modified alertify confirm dialog to modal dialog. Do review it and let me know for comments. Thanks, Neel Patel RM_3248.patch Description: Binary data

Re: pgAdmin 4 commit: Fix requirements for Python 2.6.

rity>=3.0.0 (from -r ../../requirements.txt (line 40)) (already in Flask-Security==3.0.0 (from -r ../../requirements.txt (line 15)), name='Flask-Security')* Thanks, Neel Patel On Wed, Apr 4, 2018 at 4:56 PM, Dave Page wrote: > Fix requirements for Python 2.6. > > Branch >

Re: Showstopper desktop runtime issue

Hi, On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > All, > > As you know, the 3.0 release is currently on hold as we discovered late > yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and > later. This is because the GTK project, and later Gnome, have removed > support

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

TableSpaceAddTestCase (Check Tablespace Node) ResourceGroupsAddTestCase (Add resource groups) SynonymGetTestCase (Fetch synonym Node URL) ResourceGroupsPutTestCase (Put resource groups) TableSpaceUpdateTestCase (Check Tablespace Node)

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

Hi Dave, On Tue, Nov 21, 2017 at 3:52 PM, Dave Page wrote: > Hi > > On Tue, Nov 21, 2017 at 9:33 AM, Neel Patel > wrote: > >> Hi Dave, >> >> >> On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: >> >>> >>> >>>

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

Hi Dave, On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: > > > On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Nov 20, 201

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

Hi Dave, On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: > Hi > > On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel > wrote: > >> Hi, >> >> Please find attached patch to fix RM#2679. >> >> *Issue:-* >> Getting started links does not open second t

[pgAdmin4][runtime][patch]: Fix for RM#2679

ot;_blank" so that "createWindow" signal will be called every time when user click on any link. Do review it and let me know for comments. Thanks, Neel Patel RM_2679.patch Description: Binary data

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Patel On Fri, Nov 17, 2017 at 6:44 PM, Neel Patel wrote: > Hi Dave, > > I have tried for 350K rows with query given by you but not able to > reproduce the hang issue. > I have put some debug statement in Qt Signal's handler. Can you please > apply this debug patch and pr

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi Dave, I have tried for 350K rows with query given by you but not able to reproduce the hang issue. I have put some debug statement in Qt Signal's handler. Can you please apply this debug patch and provide me console output if possible ? Thanks, Neel Patel On Fri, Nov 17, 2017 at 3:

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi Dave, On Fri, Nov 17, 2017 at 3:09 PM, Dave Page wrote: > > > On Fri, Nov 17, 2017 at 9:36 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: >> >>> >>> >>> On Fri, Nov 17, 2017 at

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi Dave, On Fri, Nov 17, 2017 at 2:42 PM, Dave Page wrote: > > > On Fri, Nov 17, 2017 at 8:45 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Nov 16, 201

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi Dave, On Thu, Nov 16, 2017 at 8:13 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 1:47 PM, Neel Patel > wrote: > >> Hi, >> >> Adding information. >> >> With this patch, RM#2715 should also be resolved. >> >> Thanks, >&g

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi, Adding information. With this patch, RM#2715 should also be resolved. Thanks, Neel Patel On Thu, Nov 16, 2017 at 7:01 PM, Neel Patel wrote: > Hi, > > I am able to reproduce the crash while downloading and save data in CSV > file from query tool. > > Please find atta

[pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

pplication. Do review it and let me know for comments. Thanks, Neel Patel RM_2829_RM_2491.patch Description: Binary data

[pgAdmin4][Patch]: RM#2716 - Automatic detect and fix value of "HKEY_CLASSES_ROOT\.css\Content Type"

tarts, it checks for registry value above and it differs from "text/css", application will change the value and notifies the user about the same. Do review it and let me know for comments. Thanks, Neel Patel RM_2716.patch Description: Binary data

[pgAdmin4][patch][runtime]: RM#2443 - No prompt while exiting application

Hi, Please find attached patch to fix RM#2443 - No prompt while existing from main pgAdmin4 runtime browser window. Do review it and let me know for comments. Thanks, Neel Patel RM_2443.patch Description: Binary data

Re: [pgAgent][Patch] Fixing connection pool leak

. @Robert - Can you also test at your environment and keep us updated for any leak ? Thanks, Neel Patel On Mon, Oct 23, 2017 at 10:30 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Rob, > > How about this? > > > -- > > Thanks & Regards, >

[patch][pgAdmin4]: RM #2738 - Line numbers of SQL tab appear above open menus

Hi, Please find attached patch with the fix of RM# 2738 where Code mirror sql line number of SQL tab appear above menus. Do review it and let me know for the comments. Thanks, Neel Patel RM_2738.patch Description: Binary data

Re: v2.0-rc1 not starting, runtime not building

nd let us know result. Thanks, Neel Patel On Thu, Sep 14, 2017 at 2:32 PM, Willy-Bas Loos wrote: > > On Thu, Sep 14, 2017 at 10:35 AM, Neel Patel > wrote: > >> Surely, there is something wrong with your Qt installation. >> Can you please try to install required "*-d

[pgAdmin4][runtime][Patch]: Fix RM #2557

Hi, Please find attached patch file for the fix of below issue in runtime. RM #2557 - UI issues with tabs on secondary windows. Do review it and let me know for comments. Thanks, Neel Patel RM_2557.patch Description: Binary data

[pgAdmin4][runtime][Patch]: Fix RM #2559

Hi, Please find attached patch file for the fix of below issue in runtime. RM #2559 - Toolbuttons ( Back/Forward/Close) on tab become 3D. I have tested with all 3 platforms. Do review it and let me know for comments. Thanks, Neel Patel RM_2559.patch Description: Binary data

Re: pgAdmin 4 v1.6 Released!

Hi, Thanks, Neel Patel On Jul 14, 2017 5:31 AM, "Shira Bezalel" wrote: I downloaded the Windows pgAdmin 1.6 version, and after launching it, it simply shows a black display. My colleague also on Windows 10 had the same experience. Does this sound like a known problem? It is no

[pgAdmin4][runtime]: Fix RM #2558

Hi, Please find attached patch file for the fix of below issue in runtime. RM #2558 - Tab bar on main window vanishes when closing child via tab button I have tested with all 3 platforms. Do review it and let me know for comments. Thanks, Neel Patel RM_2558.patch Description: Binary

Re: [pgAdmin4]: Webpacking of static JS/CSS

n windows performance issue as well :) Thanks, Neel Patel On Tue, Jul 11, 2017 at 1:27 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > I found this patch won't work on IE, so i have fixed it and will send > updated patch. > > On Tue, Jul 11, 2017 at 1