Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

/bubble up. As Khushboo is working on new switch control (RM 3051 <https://redmine.postgresql.org/issues/3051>) I haven't fix this issue as a part of this patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Compa

[pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

Hi, Please find attached patch to fix backgrid navigation using keyboard for Select2Cell and PrivilegeCell -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > This patch fixes Dialog tabset keyboard navigation. > This

[pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi, This patch fixes Dialog tabset keyboard navigation. This regression was caused due to bootstrap 4 changes. Also I have added jasmine test cases for the same -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

[pgAdmin4][RM3703] Clear user connections on logout

Hi, Please find patch to clear user connections on logout. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index 9b2cf35..36dfee3 100644 --- a/web

[pgAdmin4][Patch] RM #3700 fix connection garbage collector

Hi, This issues caused as we were iterating over manager keys (which contains server ids) and not on server managers. Attached patch fixes this issue. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

Hi Akshay, We can do one minor improvement for python 2. Instead of below check *if type(val) in (str, unicode) :* we can check val against *basestring <https://docs.python.org/2/library/functions.html#basestring>* Thanks, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India

Fix for debugger issue with EPAS package procedures/functions INOUT params #RM3191

Hi, Please find attached patch to fix below debugger issues. 1. Allow debugging of EPAS package procedures/functions with INOUT params. 2. Add Support for indirect debugging for EPAS package procedures/functions. 3. Allow debugging with NULL param values. Thanks, -- *Harshal Dhumal* *Sr

Fix for RM3547

Hi, Please find attached patch to fix RM3547 Thanks, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/session.py b/web/pgadmin/utils/session.py index fa313e0..cdf39ce 100644 --- a/web

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

On Mon, Jun 11, 2018 at 6:02 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This is regarding RM3294 which I am working on, where user needs to reset > the layout to see the changed preferences parameters. I am able to > implement it, and have used the following

Re: Bug #3083 fix

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote: > Argh, managed to send before I finished typing... > > On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote

Re: RM3079 fix for wrong sql datetime/time related datatypes

o > > On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Feb 27, 2018 at 8:54 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhum

Re: RM3079 fix for wrong sql datetime/time related datatypes

Hi, On Tue, Feb 27, 2018 at 8:54 PM, Dave Page wrote: > Hi > > On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find patch to fix wrong sql issue for time related type. >> >> Step

RM3079 fix for wrong sql datetime/time related datatypes

Hi, Please find patch to fix wrong sql issue for time related type. Steps to reproduce: Alter any time/datetime array related data type, it generates sql with addition array bracket [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http

PEP-8 fixes

Hi, Please find patch to fix pep-8 issues for given modules. 1. server group (__init__.py) 2. server (__init__.py, gpdb.py, types.py, utils.py) -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

pane. Now I have made changes that it won't process any user navigation events until current navigation is completed. > On Mon, Feb 26, 2018 at 6:04 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the updated patch.

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hi, Please find the updated patch. On Mon, Feb 26, 2018 at 8:03 PM, Dave Page wrote: > Hi > > On Mon, Feb 26, 2018 at 12:03 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the updated patch for keyboard navigat

pep-8 fixes

Hi, Please find patch to fix pep-8 issues for given modules. 1. help (__init__.py) 2. pgadmin (__init__.py) 3. browser (__init__.py, collection.py, utils.py) -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 21, 2018 at 11:39 PM, Harshal Dhumal wrote: > Hi, > > On Wed, Feb 21, 2018 at 10:59 PM, Joao De Almeida Pereira < > jdealmeidapere...@pi

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

) >>> Summing it up I believe that despite the feature not working 100% of the >>> time, looks like the code is almost there but needs some refactoring to >>> make it more readable, instead of comments we could have function calls >>> that more clearly state what we are looking for some

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 20, 2018 at 10:34 PM, Dave Page wrote: > Hi > > On Tue, Feb 20, 2018 at 7:22 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com&

RM2983: Fix transient error after application restart

Hi, Please find patch to fix specified_version_number ValueError issue. Now we try to restore server details like server version number and version string from flask session in-case if there was a application restart. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http

RM2898 Keyboard navigation in dialog tabs (nav tabs)

tab navigation. Also all dialog controls (within same tab pane) can be navigated using TAB key. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/docs/en_US/keyboard_shortcuts.rst b/docs/en_US

RM3080 Fix for alignment issue in keyboard preferences

Hi, Please find attached patch to fix alignment issue in keyboard preferences. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/__init__.py b/web/pgadmin/browser/__init__.py index

Fix for RM3052: Alter column error

Hi,. Issue was caused due to we were considering internal datatype length (eg. smallint 2 bytes, int4 4 bytes, integer 8 bytes) as user configurable length. However we cannot change internal datatype lengths of some primitive datatypes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

ftheweb.com/blog/detect-browser-window-focus>. In sqleditor there are cases where we've written conditional code based on whether sqleditor is opened in new window or not. On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Murtuza,

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Murtuza, I think we should only poll if sqleditor/datagrid is visible. We've *wcDocker.EVENT.VISIBILITY_CHANGED *event when panel visibility changes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, J

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

Hi, Please find rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 9, 2018 at 9:21 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Please find upda

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

Hi Dave, Please find updated patch where we are notifying user about connection reset. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 8, 2018 at 7:39 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 7:26 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:18 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> On Mon, Jan 8, 2018 at 6:11 PM, Dave Page wrote: >> >>> >>> >>>

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 6:11 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 12:37 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 5:15 PM, Dave Page wrote: >> >>> HI >>> >>> On Mo

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 5:15 PM, Dave Page wrote: > HI > > On Mon, Jan 8, 2018 at 11:41 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 4:34 PM, Dave Page wrote: >> >>> Hi >>> >>> On F

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

On Mon, Jan 8, 2018 at 4:34 PM, Dave Page wrote: > Hi > > On Fri, Jan 5, 2018 at 7:50 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Further details: >> >> 1. If session is expired and user performs any action from sqleditor that >&g

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

query tool. Code snippet: if(is_new_transaction_required(xhr)) { SqlEditorController.init_transaction(); } -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jan 5, 2018 at 11:44 AM, Harshal Dhumal < har

RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

Hi, Plz find attached patch to fix session expired issue from sqleditor/datadrid. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index db676c5..220ea6b

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page

Re: Enums printout - possible bug

+pgadmin-hackers -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Dec 14, 2017 at 5:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for va

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

Hi Murtuza, Moving login related code from under decorator @app.before_first_request to @app.before_request will cause runtime user to login on each request. I think we need to find some better way. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com

[pgAdmin4][RM2782][RM2822] fix array representation in query tool and data grid

Hi, Attached patch fixes array representation issue as well as multidimensional array representation issue. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/feature_tests/test_data.json b/web

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

as user passes PGADMIN_KEY with request? (this will require new session to be created for each /misc/ping request) > > On Thu, Nov 30, 2017 at 7:58 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to fix iss

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Nov 30, 2017 at 5:09 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > sure Dave, looking in it now. > > -- > *Harshal Dhumal* > *

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

sure Dave, looking in it now. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Nov 30, 2017 at 5:01 PM, Dave Page wrote: > Oh, nuts - turns out this breaks the regression tests (the Python API > tes

[pgAdmin4][RM2922] Login desktop user only once in runtime

Hi, Please find attached patch to fix issue where desktop user was logged in each request in runtime. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py

[pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

routes for these callbacks and add addition code to handle such exceptions. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index a1d10b8..0196852 100644 --- a

Re: Fix for RM2811

Hi Dave, -- On Mon, Nov 27, 2017 at 9:20 PM, Harshal Dhumal wrote: > > > On Mon, Nov 27, 2017 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 27, 2017 at 12:29 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >>

Re: Fix for RM2811

On Mon, Nov 27, 2017 at 6:32 PM, Dave Page wrote: > Hi > > On Mon, Nov 27, 2017 at 12:29 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> >> -- >> *Harshal Dhumal*

Re: Fix for RM2811

Hi Dave, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Nov 27, 2017 at 5:28 PM, Dave Page wrote: > Hi > > On Mon, Nov 27, 2017 at 11:23 AM, Harshal Dhumal < &

Fix for RM2811

might not be logged to file immediately. So we should also check process exit code along with above condition. Apart from above this patch also includes minor fix related to status text colour. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The

Fix for RM2845: Make "Save changes" prompt configurable

Hi, Please find attached patch to fix RM2845 -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/datagrid/__init__.py b/web/pgadmin/tools/datagrid/__init__.py index c37e5d3..eaa1850 100644

Fix for issue RM2760

Hi, Please find attached patch to fix RM2760 and RM2867 -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/static/js/file_manager.js b/web/pgadmin/misc/file_manager/static/js

Fix for minor issue RM2868

Hi, Path to fix minor issue "local variable 'password' referenced before assignment." -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__ini

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi Murtuza, I think for tables having row count more than preference count it should show preference count with plus '+' sign instead empty. eg. 2000+ (for table with rows more than 2000 and for preference count of 2000.) [image: Inline image 1] -- *Harshal Dhumal* *Sr. Softwar

Re: pgadmin4 exception: session['_id'] not in self.managers

Hi Dave, Please find attached patch (old RM2713). Also for server group and server module login required checks were missing, I have added them in same patch -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue

Re: pgAdmin 4 commit: Update release notes.

Hi Dave, I think RM2671 is missing in release notes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 28, 2017 at 2:51 PM, Dave Page wrote: > Update release notes. > > Branch > ---

Fix for Exception when the server is restarted [RM2713][pgAdmin4]

ay to keep sessions from memory and disk in sync as user logged in status is kept in session. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index b2

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

I think this is similar issue.. https://redmine.postgresql.org/issues/2134 On Mon, Sep 18, 2017 at 11:16 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apache > server due to python error. > > [mod_wsgi (pid=1

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

they will translated before sending to server. Apart from this I found that data types "char" and "char"[] (alias to character and character[] respectively) were not taken into consideration in sqleditor.js. I have attached updated patch which fixes this issue. --

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

t; wrote: >>> >>>> >>>> >>>> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: >>>> >>>>> Adding Akshay... >>>>> >>>> >>>> Sure. >>>> >>>>> >>>>

Array representation and save array data from datagrid [RM2671][pgAdmin4]

Hi, Please find attached patch to represent array data in datagrid with curly braces and also allow user to save array with values like , , ' *""*' and "*''*" -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.co

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #11

Hi Dave, Please attached patch to fixed Querytool feature test cases (RM2681 <https://redmine.postgresql.org/issues/2681>). -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 4, 2017 at 9:02 PM, pgA

Array representation [pgAdmin4]

hey do appear for real, bigint, float, etc array data types. Also additional efforts will required If we plan to represent like pgAdminIII as we'll need to update/add slickgrid cell editors/formatter for array data types. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB

Fix for RM2670

Hi, Please find minor patch to improve datamodel validations for default Validator if user (developer) do not implement validate function in datamodel. Without this default validation error messages were suppressing if no validation function was provided. -- *Harshal Dhumal* *Sr. Software

Re: pgAdmin 4 commit: Fix the feature tests failuers.

name from *test_function* to *a_test_function *so that it will appear at top position under function collection node (patch attached). -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Aug 25, 2017 at 9:11 PM, A

Re: [pgAdmin4][RM2586] Cleanup feature test

Hi, Please find attached updated patch On Fri, Aug 25, 2017 at 2:32 PM, Dave Page wrote: > Hi > > On Thu, Aug 24, 2017 at 11:51 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Last week Sarah, Matt and I had call regarding

Re: fix keyerror problems

how about this? default_path = ( config.DEFAULT_BINARY_PATHS.get(st.stype, "") ) On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer wrote: > See attached patch > > > Dave Cramer >

Re: Next release

One more thing that this will only work for future pgAdmin4 versions -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Aug 25, 2017 at 1:48 PM, Dave Page wrote: > > > On Fri, Aug 25, 2017 at 9:15 AM,

Re: Next release

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 24, 2017 at 9:44 PM, Dave Page wrote: > > > On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> w

Re: [pgAdmin4][RM2586] Cleanup feature test

s, Harshal -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Aug 11, 2017 at 11:55 AM, Sarah McAlear wrote: > Great job on cleaning up the whole feature test suite! This is really > going to benefit all of

Re: [pgAdmin4][RM2586] Cleanup feature test

hanks, Harshal -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 7, 2017 at 8:55 AM, Sarah McAlear wrote: > Hi Harshal! > > There are a few files in which there are leftover imports that are not &g

Re: [PATCH] Work with newer Flask-Security.

issue and also attached patch from same. Thanks -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 7, 2017 at 7:08 PM, Ashesh Vashi wrote: > Harshal, > > Please take a look at it. > > --

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi wrote: > On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to use fetch dict based data instead of 2d-array based in >> Type module as we are adding keys on the fly. >> There is no RM just a mino

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

On Fri, Aug 4, 2017 at 6:32 PM, Ashesh Vashi wrote: > Harshal, > > On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > >> Ashesh, can you deal with this please? Thanks. >> >> On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please fi

Re: [pgadmin4] unable to pull remote

hi Change below url in your git config from *git://git.postgresql.org/git/pgadmin4.git <http://git.postgresql.org/git/pgadmin4.git>* to *http://git.postgresql.org/git/pgadmin4.git <http://git.postgresql.org/git/pgadmin4.git>* -- *Harshal Dhumal* *Sr. Software Engineer* Enterp

[pgAdmin4][RM2586] Cleanup feature test

with timing. 4. Improved debugger XSS test case execution time. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/feature_tests/connect_to_server_feature_test.py b/web/pgadmin/feature_tests

Re: pgAdmin 4 commit: Fix test assertion.

Well I'm able run all feature test cases on python 2.7 with latest pull. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 31, 2017 at 5:43 PM, Robert Eckhardt wrote: > It fails because the

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi Dave, EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 26, 2017 at 5:41 PM, Dave Page wrote: > > > On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >>

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi, On Mon, Jul 24, 2017 at 4:23 PM, Dave Page wrote: > Hi > > On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to set default layout of file listing as a >> li

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: > >> 2-3 days is a lot of valuable en

[RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi, Please find attached patch to set default layout of file listing as a list in file manager. Also replaced alertify with out custom alertifywrapper in file manager utils.js -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Jul 21, 2017 4:23 PM, "Dave Page" wrote: On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 20

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi, On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > Hi > > On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Currently if user clicks on empty white area below history entry then >> arro

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi, Currently if user clicks on empty white area below history entry then arrow navigation does not work. Attached patch fixes this issue. [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi Dave, On Tue, Jul 18, 2017 at 8:31 PM, Dave Page wrote: > > > On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: >> >>> &

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

On Tue, Jul 18, 2017 at 9:33 PM, pgAdmin 4 Jenkins wrote: > See feature/8/display/redirect?page=changes> > > Changes: > > [Dave Page] Use client-side url_for in the sql editor and data grid > modules. > > [Dave Page] Ensure revoked publ

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi Dave, On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: > > > On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> >> On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: >> >

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi Dave, On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: > Hi > > On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch. Now placeholder string for bytea and bytea[] >>

[RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi, Please find attached patch to handle bytea and bytea[] data in datagrid. Now instead of showing actual data we can show placeholders like and . Also placeholders will only appear if data actually exists otherwise null will be shown. -- *Harshal Dhumal* *Sr. Software Engineer

[RM2153][pgAdmin4] handle large file uploads

Hi, Please find attached patch to handle upload of large files and also to show upload error if error occurs instead of showing undefined. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc

[RM2544][pgAdmin4] Fix for malformed query generated when using custom type

Hi, Please find attached patch to fix malformed sql for data type. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/templates/type/macros

[RM2551][pgAdmin4] show tablespace on partitions.

Hi, Please find attached patch to show tablespace on partitions. Also reformatted sql slightly in sql tab. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers

Re: pgAdmin 4 commit: Release notes for 1.6.

port for the hostaddr connection parameter. This helps us play >nicely with Kerberos/SSPI and friends -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 10, 2017 at 7:22 PM, Dave Page wrote: > Rel

[RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

Hi, Please find attached patch to fix issue related to table OF TYPE property. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js

Fix clear history option [pgAdmin4][RM2535]

Hi, Please find attached patch to fix clear history functionality in query tool. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/history/history_collection.js b/web/pgadmin/static

[RM1972][pgAdmin4] Improve query tool close workflow.

Hi, Please find attached patch for to allow user to save changed query or data when closing query tool/datagrid. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/feature_tests

Patch for sqleditor js syntax issue

Hi, Please find attached minor patch which fixes js syntax issue in sqleditor.js -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web

Re: [RM2522] Improve grid/column select all operation

result set recursively and then removes duplicate which is not required in our case. All we want is indexes of complete rows in selected rows (ranges). -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 30, 2017

Re: [RM2522] Improve grid/column select all operation

On Thu, Jun 29, 2017 at 4:33 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for RM2522. > > With this patch grid/column select all time is reduce to ~1 second from > 8-10 seconds. > This benchmarking is performed with 1

[RM2522] Improve grid/column select all operation

row selection. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/selection/range_selection_helper.js b/web/pgadmin/static/js/selection/range_selection_helper.js index 25cd63c..4442f2c

Re: [pgadmin-hackers][patch] History Detail Pane

Hi, New history pane is really nice and informative than existing one. I'm just thinking about one minor improvement we can make, to allow history tab to respond to up and down arrow keys so that user can easily switch between executed queries without using mouse. Thanks, -- *Harshal D

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

$(queryToolPanel).data('embeddedFrame', frame); + + // Set panel title and icon queryToolPanel.title(''+panel_title+''); queryToolPanel.icon('fa fa-bolt'); Surinder is looking into this. I'm holding patch for RM2137 (on demand load

  1   2   >