Re: [pgAdmin][patch] React based Modal provider to replace Altertify alert

2021-12-02 Thread Akshay Joshi
Thanks, the patch applied. On Fri, Dec 3, 2021 at 12:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch adds a React based modal provider to pgAdmin. It can be > used to create modals on the fly. > Based on this, I've created two functions - alert

pgAdmin 4 commit: Fixed unhashable type issue while opening the about d

2021-12-02 Thread Akshay Joshi
Fixed unhashable type issue while opening the about dialog. Fixes #7048 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c0c046a38ed8a59588dff4ca09bc42f60c5fba7 Modified Files -- docs/en_US/release_notes_6_3.rst | 1 + web/pgadmin/_

pgAdmin 4 commit: Implemented React based modal provider to create mode

2021-12-02 Thread Akshay Joshi
Implemented React based modal provider to create models on the fly. Also, use this to replace Alertify alert and confirm dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfdaf7f6d19c3efb7f9959f8b18ea0407996d0f1 Author: Aditya Toshniwal

pgAdmin 4 commit: Fixed API test cases for StartRunningQueryTest.

2021-12-02 Thread Akshay Joshi
Fixed API test cases for StartRunningQueryTest. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8cb62180e81e49385ab7390a481d71c20bab882 Modified Files -- .../tools/sqleditor/utils/tests/test_start_running_query.py| 10 +---

[pgAdmin][patch] React based Modal provider to replace Altertify alert

2021-12-02 Thread Aditya Toshniwal
Hi Hackers, Attached patch adds a React based modal provider to pgAdmin. It can be used to create modals on the fly. Based on this, I've created two functions - alert and confirm in the Notifier. This will help to replace Alertify alert and confirm. Please review. -- Thanks, Aditya Toshniwal pg

pgAdmin 4 commit: Corrected the down_version in migration file.

2021-12-02 Thread Akshay Joshi
Corrected the down_version in migration file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ae1036a246202830a510273b273cb6a6fbbd951 Modified Files -- web/migrations/versions/15c88f765bc8_.py | 2 +- 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Added support for Two-factor authentication for impro

2021-12-02 Thread Akshay Joshi
Added support for Two-factor authentication for improving security. Fixes #6543 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36c9eb3dfd9202c5ab46272d573619c75cfdd79a Author: Ashesh Vashi Modified Files -- .dockerignore

Re: [pgAdmin][7046] Accessibility fixes

2021-12-02 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Dec 1, 2021 at 6:37 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to fix the below accessibility issues: > >- Focus is not visible while navigating through top navbar menu >items(File, Object

Re: [pgAdmin][RM7031]: Database definition wrong

2021-12-02 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Dec 2, 2021 at 3:09 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. > > On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Pradip, >> >> You did

pgAdmin 4 commit: Fixed some accessibility issues:

2021-12-02 Thread Akshay Joshi
Fixed some accessibility issues: 1) Focus is not visible while navigating through top navbar menu items(File, Object, Tools) 2) In preference dialog wherever access key is used for a shortcut declaration, unable to get out of the textbox. 3) Focus is not visible for the links on the dashboard Fi

pgAdmin 4 commit: Change the logic to rename the table in the SQLite da

2021-12-02 Thread Akshay Joshi
Change the logic to rename the table in the SQLite database to fix the migration issue. refs #7031 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe096116be1b36f57665b34672f238e112a72d92 Author: Pradip Parkale Modified Files --

pgAdmin 4 commit: Replaced alertifyjs notifiers with React-based notist

2021-12-02 Thread Akshay Joshi
Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6424e3897a3476a0cd7563b20ab1c5f4b79e70b Modified Files -- docs/en_US/release_notes_6_3.rst |

Re: [pgAdmin][RM7031]: Database definition wrong

2021-12-02 Thread Pradip Parkale
Hi Akshay/Aditya, Please find the updated patch. On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Pradip, > > You did not include the server_old table for query_history. > Fixed. > Please also remove the commented code: > +# db.engine.execute(