Re: Patch for Bug #6832

2021-10-17 Thread Khushboo Vashi
Hi Florian, The patch will fail if we have AUTHENTICATION_SOURCES = ['ldap', 'oauth2'] settings. Also, please rebase your patch. Thanks, Khushboo On Wed, Oct 13, 2021 at 4:03 PM Florian Sabonchi wrote: > Hello I have written a patch for the bug #6832 > >

Re: feature #6640

2021-10-17 Thread Khushboo Vashi
Hi Florian, Review comments: - Allowed_organisation is introduced for all, so the code comments and documentation should reflect it. Github should be an example of that. - The below code checks all the Oauth2 configs, so if I have set ALLOWED_ORGANIZATIONS for only github, it will check for all t