Re: [pgAdmin][RM-6826]: [React] Message "Error while saving grant wizard data" with user defined functions

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 30, 2021 at 10:05 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for > RM-6826: > [React] Message "Error while

pgAdmin 4 commit: Fixed an issue while saving grant wizard data with us

2021-09-29 Thread Akshay Joshi
Fixed an issue while saving grant wizard data with user-defined functions. Fixes #6826 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3da85f415decb525305c498bb10cec689b3aae10 Author: Nikhil Mohite Modified Files -- web/pgadmin/s

pgAdmin 4 commit: Use the correct way to update the state variable usin

2021-09-29 Thread Akshay Joshi
Use the correct way to update the state variable using depChange method. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=031167fbeaa17002482a7c96cfa1c70c1e322fa3 Modified Files -- .../servers/pgagent/steps/static/js/pga_jobstep.ui.

[pgAdmin][RM-6826]: [React] Message "Error while saving grant wizard data" with user defined functions

2021-09-29 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6826: [React] Message "Error while saving grant wizard data" with user defined functions. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Po

pgAdmin 4 commit: Fixed linter error.

2021-09-29 Thread Akshay Joshi
Fixed linter error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ac38a076b9ddb1f86fef2080f48a65b395f6c41 Modified Files -- .../server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js | 2 +- 1 file changed, 1 inserti

Re: [pgAdmin][RM-6803 & RM-6804]: Trigger Node - [Create]> For constraint trigger only After event should be displayed, [Properties Panel/Edit Properties]> Incorrect values for Constraint trigger, Def

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 6:24 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the combined patch for RM-6803 > and RM-6781 > > > > On Mon, Sep

pgAdmin 4 commit: 1) Fixed pgAgent related issues. Fixes #6827

2021-09-29 Thread Akshay Joshi
1) Fixed pgAgent related issues. Fixes #6827 2) Added helpMessageMode parameter to hide help messages from properties panel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b6ab6b3bb82ee362967cdfbb549f2b1b424b5e0 Modified Files --

pgAdmin 4 commit: 1) Fixed accessibility issues for Trigger functions.

2021-09-29 Thread Akshay Joshi
1) Fixed accessibility issues for Trigger functions. Fixes #6803 2) Fixed incorrect privileges value in Materialize View. Fixes #6781 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c80ea7ae89c356a662616972f50fc1c29f47e0a1 Author: Nikhil Mohite

Re: [pgAdmin][RM-6803 & RM-6804]: Trigger Node - [Create]> For constraint trigger only After event should be displayed, [Properties Panel/Edit Properties]> Incorrect values for Constraint trigger, Def

2021-09-29 Thread Nikhil Mohite
Hi Akshay, Please find the combined patch for RM-6803 and RM-6781 On Mon, Sep 27, 2021 at 11:33 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Fri, Sep 24, 2021 at 6:51 PM Nikhil Mohite < > ni

Re: [pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 3:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached patch fixes jasmine test cases failing because of previous patch. > > On Wed, Sep 29, 2021 at 3:24 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: [pgAdmin4][Patch] - Fixes for RM #6817, #6821, #6824

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 4:40 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the rebased patch. > > Thanks, > Khushboo > > On Wed, Sep 29, 2021 at 4:02 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please

pgAdmin 4 commit: Fixed Jasmine test cases.

2021-09-29 Thread Akshay Joshi
Fixed Jasmine test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c57fc74e183b94b91ee9564bb2bf2f14bd0a5e3d Author: Aditya Toshniwal Modified Files -- .../servers/databases/schemas/tables/static/js/table.ui.js| 11 +

pgAdmin 4 commit: 1) Browser panel turns blank on connecting disconnect

2021-09-29 Thread Akshay Joshi
1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817 2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821 3) Object gets deselected after editing. Fixes #6824 Branch -

Re: [pgAdmin4][Patch] - Fixes for RM #6817, #6821, #6824

2021-09-29 Thread Khushboo Vashi
Hi, Please find the rebased patch. Thanks, Khushboo On Wed, Sep 29, 2021 at 4:02 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the below RMs: > > #6817 - Browser panel turns blank on connecting disconnected database & > server has mu

[pgAdmin4][Patch] - Fixes for RM #6817, #6821, #6824

2021-09-29 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below RMs: #6817 - Browser panel turns blank on connecting disconnected database & server has multiple databases #6821 -Object is not selected/properties panel is not updated when user moves to object with arrow keys #6824 - Object get deselected af

Re: [pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Aditya Toshniwal
Hi, Attached patch fixes jasmine test cases failing because of previous patch. On Wed, Sep 29, 2021 at 3:24 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Sep 29, 2021 at 3:09 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patc

Re: [pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 3:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch removes redundant empty option for Exclusion > constraint access method name, Of type and Like relations. > > Please review. > > -- > Thanks, >

pgAdmin 4 commit: Fixed API test caes for Domain node.

2021-09-29 Thread Akshay Joshi
Fixed API test caes for Domain node. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82935ad3be777bf59e15bf3e2cf5dc9e277836f5 Modified Files -- .../servers/databases/schemas/domains/tests/test_domain_sql.py| 4 ++-- 1 file c

pgAdmin 4 commit: Remove redundant empty option for Exclusion constrain

2021-09-29 Thread Akshay Joshi
Remove redundant empty option for Exclusion constraint access method name, Of type, and Like relations. Fixes #6825 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28892bb07f8467078c96d654366311d4ae6bd2e6 Author: Aditya Toshniwal Modified Fi

[pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch removes redundant empty option for Exclusion constraint access method name, Of type and Like relations. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE

Re: [patch][pgAdmin] RM6822 User can not expand the server on Windows

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 12:24 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the tree expanding issue on > windows. > > Fix is tested on Windows 2016 & Mac. > > -- > *Rahul Shirsat* > Senior Soft

Re: [pgAdmin][RM6815]: Language Node > Edit dialogue allows clearing owner field.

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 1:03 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for #6815: Language Node > Edit dialogue > allows clearing owner field. > > This patch also includes the fix for #6823: [React] Lang

Re: [pgAdmin][RM6816] Date time control related fixes

2021-09-29 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 29, 2021 at 1:35 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Date time control not working on firefox. > 2. Replace moment with date-fns in date time control as date-fns is more > maintained. >

pgAdmin 4 commit: 1) Ensure the edit dialog should not allow clearing o

2021-09-29 Thread Akshay Joshi
1) Ensure the edit dialog should not allow clearing owner in the Language node. Fixes #6815 2) Fixed an issue where the Language node is disabled for the functions for EPAS/PG 9.6 and 10. Fixes #6823 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commi

pgAdmin 4 commit: 1. Date time control not working on firefox.

2021-09-29 Thread Akshay Joshi
1. Date time control not working on firefox. 2. Replace moment with date-fns in date time control as date-fns is more maintained. Fixes #6816 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=332351efafbfdd1ffdb912445c76e915a9f8b74f Author: Adi

pgAdmin 4 commit: Fixed an issue where the user was not able to expand

2021-09-29 Thread Akshay Joshi
Fixed an issue where the user was not able to expand the server's on Windows. Fixes #6822 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=77d0409c5bb1524518f5e1f518c5aa054e2727d0 Author: Rahul Shirsat Modified Files -- web/pgadmi

[pgAdmin][RM6816] Date time control related fixes

2021-09-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Date time control not working on firefox. 2. Replace moment with date-fns in date time control as date-fns is more maintained. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't C

pgAdmin 4 commit: Reverting 'Two-factor authentication' support as it c

2021-09-29 Thread Akshay Joshi
Reverting 'Two-factor authentication' support as it cause OSX and docker build failures. This reverts commit 787a441343988c8e0b24876cc6d3cb81dee317af. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d07770244dd7610ef289d4ba19fc8841949f726 M

[pgAdmin][RM6815]: Language Node > Edit dialogue allows clearing owner field.

2021-09-29 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6815: Language Node > Edit dialogue allows clearing owner field. This patch also includes the fix for #6823: [React] Language node is disabled for the functions for EPAS/PG 9.6 and 10. -- Thanks & Regards, Pradip Parkale Software Engineer | Enterp