pgAdmin 4 commit: Handler and Validator should not allow selecting the

2021-09-27 Thread Akshay Joshi
Handler and Validator should not allow selecting the empty options. Fixes #6810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2265ffc0a710882cad53f39e3335596e4ca866b6 Modified Files -- .../server_groups/servers/databases/foreign_

Re: [pgAdmin][RM-6813]: SQL is not getting generated for Foreign table >> option

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 5:17 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for > RM-6813: > [React] SQL is not getting >

Re: [pgAdmin][patch] UI Improvements

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 5:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with one more improvement - Use server_type > instead of type from the server info. > > On Mon, Sep 27, 2021 at 4:57 PM Aditya To

Re: [patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 8:32 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the issues of sort & nulls > in index. > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation.

Re: [pgAdmin][RM6799]: [React] User can not Add parameter for PG procedures and Functions

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Sep 28, 2021 at 9:01 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for following issue: > >1. Not able to add Parameters for Functions and Procedures >2. For procedure, Volatility option shou

pgAdmin 4 commit: 1. Switch control and CodeMirror control UI improveme

2021-09-27 Thread Akshay Joshi
1. Switch control and CodeMirror control UI improvements for read-only and disabled states. 2. If a form input value changes to null, pass it as an empty string in URL params. 3. Use server_type instead of type from the server info. Branch -- master Details --- https://git.postgresql.or

pgAdmin 4 commit: 1. Syntax error displayed If the table is not availab

2021-09-27 Thread Akshay Joshi
1. Syntax error displayed If the table is not available and the user tries to use the blank option. Fixes #6793 2. Not able to add Parameters for Functions and Procedures. 3. For the procedure, the Volatility option should be disabled in some cases. Fixes #6799 Branch -- master Details

pgAdmin 4 commit: Fixed an issue where SQL is not getting generated for

2021-09-27 Thread Akshay Joshi
Fixed an issue where SQL is not getting generated for Foreign table options. Fixes #6813 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48a5143485d396c395e178221691f0e43681bc1f Author: Nikhil Mohite Modified Files -- .../databas

pgAdmin 4 commit: Fixed an issue for sort and null controls for the Ind

2021-09-27 Thread Akshay Joshi
Fixed an issue for sort and null controls for the Index node. Fixes #6791 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15ecf5d8210d0819d5757ca0bb609ce80bceb03a Author: Rahul Shirsat Modified Files -- .../schemas/tables/indexes/

pgAdmin 4 commit: Hardcoded the version of NWjs to 0.55.0 in the build

2021-09-27 Thread Akshay Joshi
Hardcoded the version of NWjs to 0.55.0 in the build scripts, as the latest version cause some problems. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f6a9af0aa476019b3cf9ae84f53c4b6a7bcfd798 Modified Files -- Make.bat

[pgAdmin][RM6799]: [React] User can not Add parameter for PG procedures and Functions

2021-09-27 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for following issue: 1. Not able to add Parameters for Functions and Procedures 2. For procedure, Volatility option should be disabled in some cases. This patch also includes the fix for RM6793: [React] Syntax error displayed If table is not avai

[patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable

2021-09-27 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issues of sort & nulls in index. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6791.patch Description: Binary data

Re: [pgAdmin][patch] UI Improvements

2021-09-27 Thread Aditya Toshniwal
Hi Hackers, Please find the updated patch with one more improvement - Use server_type instead of type from the server info. On Mon, Sep 27, 2021 at 4:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch incorporates: > 1. Switch control and CodeMirr

[pgAdmin][RM-6813]: SQL is not getting generated for Foreign table >> option

2021-09-27 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6813: [React] SQL is not getting generated for Foreign table >> option -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres*

[pgAdmin][patch] UI Improvements

2021-09-27 Thread Aditya Toshniwal
Hi Hackers, Attached patch incorporates: 1. Switch control and CodeMirror control UI improvements for readonly and disabled state. 2. If a form input value changes to null, pass it as an empty string in URL params. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect |

Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 1:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > All the review comments are fixed, please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Sep 24, 2021 at 4:25 PM Akshay Joshi < > akshay.jo...@

pgAdmin 4 commit: Port browser tree to React. Fixes #6129

2021-09-27 Thread Akshay Joshi
Port browser tree to React. Fixes #6129 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=483e2ca8d0aa96fa0cf7cd77a41e198b3be7d3bf Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_6_0.rst | 1 + w

Re: [pgAdmin4][patch] error message is incorrect in domains

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 2:27 PM zhangj...@fujitsu.com wrote: > Hi, all > > In domains's create function, res is used for all error messages. > I don't think this is correct. > On line 13, doid should be used as the error message.Because the execution > result of line 1

pgAdmin 4 commit: Correct the variable names in the error messages for

2021-09-27 Thread Akshay Joshi
Correct the variable names in the error messages for the Domain node. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9832256839c8410663a4a237acb672e6f7f34c3 Author: zhangj...@fujitsu.com Modified Files -- .../servers/databases/s

[pgAdmin4][patch] error message is incorrect in domains

2021-09-27 Thread zhangj...@fujitsu.com
Hi, all In domains's create function, res is used for all error messages. I don't think this is correct. On line 13, doid should be used as the error message.Because the execution result of line 11 is doid. On line 21, scid should be used as the error message.Because the execution result of line

Re: [patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab

2021-09-27 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 27, 2021 at 1:23 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the issue of schema icon not > visible in drop down of Type Node in General Tab. > > -- > *Rahul Shirsat* > Senior Soft

pgAdmin 4 commit: Fixed an issue where Schema icon is not visible in th

2021-09-27 Thread Akshay Joshi
Fixed an issue where Schema icon is not visible in the drop-down of General tab. Fixes #6806 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8d88b948a0cfccb7847b66a59a136d03980a88c Author: Rahul Shirsat Modified Files -- .../ser

[patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab

2021-09-27 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of schema icon not visible in drop down of Type Node in General Tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6806.patch Description: Binary data

pgAdmin 4 commit: Updated screenshots for server group and server dialo

2021-09-27 Thread Akshay Joshi
Updated screenshots for server group and server dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31339737a65c0e2ad2f1a7f5239198bf37c00a23 Modified Files -- docs/en_US/images/server_advanced.png | Bin 56042 -> 60989 bytes d