[pgAdmin][patch] ERD table dialog failing to open

2021-09-20 Thread Aditya Toshniwal
Hi Hackers, As the primary key backbone model is removed after porting, ERD table dialog is failing to open. Attached patch will restore the removed model until ERD dialogs are ported to React based view. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostg

pgAdmin 4 commit: Fixed RESQL test cases for Partition table using COLL

2021-09-20 Thread Akshay Joshi
Fixed RESQL test cases for Partition table using COLLATE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56a17f7c8eacf56a52bdd4c0b8aa4fdb011cd524 Modified Files -- .../tests/pg/10_plus/create_partition_table_with_collate.sql

pgAdmin 4 commit: Added PG/EPAS 14 binary path entry in the preferences

2021-09-20 Thread Akshay Joshi
Added PG/EPAS 14 binary path entry in the preferences dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=522a92586aefce69e043cfab1fa4004fe25c0516 Modified Files -- web/config.py | 4 +++- web/pgadmin/utils/cons

Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-09-20 Thread Akshay Joshi
Hi Nikhil As per the discussion, we need to create a flag for whether to add the 'IF EXISTS" clause or not. Please send the combined patch after fixing that for all the nodes. On Mon, Sep 20, 2021 at 3:58 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the

Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-09-20 Thread Nikhil Mohite
Hi Akshay, Please find the patch for RM-5741. Updated missing sql checks for following nodes: 1. Role 2. Resources Group 3. Schema 4. Language 5. Tablespace Regards, Nikhil Mohite On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi wrote: > Thanks, the patch applied to the React_Porting branch as it

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-09-20 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Patch not applied, rebas

pgAdmin 4 commit: Fixed following issues for Type dialog:

2021-09-20 Thread Akshay Joshi
Fixed following issues for Type dialog: 1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue. 2. Range Type - Loading icons are shown in different drop-down tabs. Fixes #6744 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-09-20 Thread Rahul Shirsat
Hi Akshay, Please find the updated patch. On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi wrote: > Hi Rahul > > Patch not applied, rebase and send the patch again. > > On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the at

Re: [pgAdmin][patch]: Password field issue.

2021-09-20 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Sep 20, 2021 at 11:37 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch to resolve the issue password field showing plain > text. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postg

pgAdmin 4 commit: 1) Port Grant Wizard to react. Fixes #6687

2021-09-20 Thread Akshay Joshi
1) Port Grant Wizard to react. Fixes #6687 2) Fixed an issue where grant wizard is unresponsive if the database size is huge. Fixes #2097 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aa213a5cef9a4442f037e832635953997973835 Author: Nikhil M

pgAdmin 4 commit: Fixed the issue where password field is showing as pl

2021-09-20 Thread Akshay Joshi
Fixed the issue where password field is showing as plain text. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d27b4831d651397e4c7e882b41743679c54ae6c1 Author: Nikhil Mohite Modified Files -- web/pgadmin/static/js/components/FormC