Re: [pgAdmin][RM-4567]: Privileges revoked using SQL query on objects like tables does not correctly in SQL tab

Thanks, the patch applied. On Tue, Aug 31, 2021 at 4:13 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch to fix the RESQL test cases. > > On Tue, Aug 31, 2021 at 2:09 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >

pgAdmin 4 commit: Fixes RESQL test cases.

Fixes RESQL test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=87c86beb38c39ac28c65125935cf3ad7e1e4c1b7 Author: Nikhil Mohite Modified Files -- .../schemas/tables/tests/pg/12_plus/alter_table_update_grants.sql | 2 +

Re: [pgAdmin][RM-4567]: Privileges revoked using SQL query on objects like tables does not correctly in SQL tab

Hi Akshay, PFA patch to fix the RESQL test cases. On Tue, Aug 31, 2021 at 2:09 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Tue, Aug 31, 2021 at 1:59 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the update patch (v2), resolved issue

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

Thanks, the patch applied. On Tue, Aug 31, 2021 at 2:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Aug 31, 2021 at 1:25 PM Nico Rikken > wrote: > >> Thanks for reviewing. Indeed this is a bandaid to expand the usability of >> the OAuth implementation. As I've writt

pgAdmin 4 commit: Introduced OAUTH2_SCOPE variable for the Oauth2 scope

Introduced OAUTH2_SCOPE variable for the Oauth2 scope configuration. Fixes #6627 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d13d2c6dda62ae7b12f41515960cb5762a654433 Author: Nico Rikken Modified Files -- docs/en_US/oauth2.rst

Re: [pgAdmin][RM-4567]: Privileges revoked using SQL query on objects like tables does not correctly in SQL tab

Thanks, the patch applied. On Tue, Aug 31, 2021 at 1:59 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the update patch (v2), resolved issue reported in the testing. > > > Regards, > Nikhil Mohite > > On Fri, Aug 27, 2021 at 12:55 PM Akshay Joshi < > akshay

pgAdmin 4 commit: Fixed an issue where Revoke all is not displayed if t

Fixed an issue where Revoke all is not displayed if the user change privilege. refs #4567 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=620e3a803dd2a5b69d2fb2e32734a6bf64f4c0b5 Author: Nikhil Mohite Modified Files -- .../browse

pgAdmin 4 commit: Increase the width of the user management dialog.

Increase the width of the user management dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e0bd557d959691380763634357ef6e2e2d41125 Modified Files -- web/pgadmin/tools/user_management/static/js/user_management.js | 2 +- 1 fi

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

On Tue, Aug 31, 2021 at 1:25 PM Nico Rikken wrote: > Thanks for reviewing. Indeed this is a bandaid to expand the usability of > the OAuth implementation. As I've written on the redmine issue as well > https://redmine.postgresql.org/issues/6627 I've tested my usecase with a > modified scope by pa

Re: [pgAdmin][RM-4567]: Privileges revoked using SQL query on objects like tables does not correctly in SQL tab

Hi Akshay, Please find the update patch (v2), resolved issue reported in the testing. Regards, Nikhil Mohite On Fri, Aug 27, 2021 at 12:55 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Fri, Aug 27, 2021 at 11:33 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

Thanks for reviewing. Indeed this is a bandaid to expand the usability of the OAuth implementation. As I've written on the redmine issue as well https://redmine.postgresql.org/issues/6627 I've tested my usecase with a modified scope by patching the oauth2.py file in production. That works well

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

Hi, Note that this patch just includes the configurable Scope (which would be helpful in OpenID connect), it does not include the proper OIDC implementation. Thanks, Khushboo On Tue, Aug 31, 2021 at 12:52 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

Hi, The patch looks good to me. Please find the attached patch for the same. Thanks, Khushbo On Sun, Aug 29, 2021 at 7:46 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review/test the patch? > > On Fri, Aug 27, 2021 at 7:46 PM Nico Rikken > wrote: > >> In certain cases like with Ope