Re: Bug #6337 Patch

2021-07-19 Thread Akshay Joshi
On Mon, Jul 19, 2021 at 6:23 PM Dave Page wrote: > Hi > > On Mon, Jul 19, 2021 at 1:22 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Florian >> >> Following are the review comments: >> >>- The "MAX_LOGIN_ATTEMPTS" parameter is not present in the *config.py*. >>It shoul

Re: Bug #6337 Patch

2021-07-19 Thread Dave Page
Hi On Mon, Jul 19, 2021 at 1:22 PM Akshay Joshi wrote: > Hi Florian > > Following are the review comments: > >- The "MAX_LOGIN_ATTEMPTS" parameter is not present in the *config.py*. >It should be there with some default value maybe 3. >- Can be added like > >

Re: Bug #6337 Patch

2021-07-19 Thread Akshay Joshi
Hi Florian Following are the review comments: - The "MAX_LOGIN_ATTEMPTS" parameter is not present in the *config.py*. It should be there with some default value maybe 3. - Can be added like ## # MAX_LOGIN_ATTEMPTS w

Re: SQLAlchemy updates for check tables.

2021-07-19 Thread Dave Page
On Mon, Jul 19, 2021 at 9:58 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 19, 2021 at 2:17 PM Dave Page wrote: > >> Hi >> >> On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attach

Re: SQLAlchemy updates for check tables.

2021-07-19 Thread Khushboo Vashi
On Mon, Jul 19, 2021 at 2:17 PM Dave Page wrote: > Hi > > On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for SQLAlchemy updates for check table is >> present in the database or not. (This will resolve

Re: SQLAlchemy updates for check tables.

2021-07-19 Thread Dave Page
Hi On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for SQLAlchemy updates for check table is > present in the database or not. (This will resolve load and dump server.) > How come this upstream change didn't

Re: SQLAlchemy updates for check tables.

2021-07-19 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jul 19, 2021 at 11:45 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA updated the patch to make it work with an older version of SQLAlchemy. > > On Mon, Jul 19, 2021 at 11:36 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-07-19 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jul 19, 2021 at 1:49 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch.I have added a more reliable solution to > solve this issue. > > On Wed, Jun 23, 2021 at 12:52 PM Akshay Joshi < > akshay.jo...@enterpri

pgAdmin 4 commit: Added exception handling for SQLAlchemy function to c

2021-07-19 Thread Akshay Joshi
Added exception handling for SQLAlchemy function to check the table exists or not. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5768ade198bda653c7b20fc15574b8c8a8e6aceb Author: Nikhil Mohite Modified Files -- .../browser/tests

pgAdmin 4 commit: Fixed an issue in the search object when searching in

2021-07-19 Thread Akshay Joshi
Fixed an issue in the search object when searching in 'all types' or 'subscription' if the user doesn't have access to the subscription. Fixes #6448 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2205fc6e178638dff9062e9b6c469c207b5e688 Autho

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-07-19 Thread Pradip Parkale
Hi Akshay, Please find the updated patch.I have added a more reliable solution to solve this issue. On Wed, Jun 23, 2021 at 12:52 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Tue, Jun 22, 2021 at 4:17 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >>