Re: [pgAdmin][Patch] - Housekeeping #6582 - [React] Port Extension object to react

Hi, Please find the updated patch.(..v2.patch) Thanks, Yogesh Mahajan EnterpriseDB On Tue, Jul 6, 2021 at 11:05 AM Akshay Joshi wrote: > Hi Yogesh > > Porting is not reflected at all still the old dialog is visible. Please > check and resend the updated patch. > > On Mon, Jul 5, 2021 at 8:40

Re: [pgAdmin][Patch] - Housekeeping #6582 - [React] Port Extension object to react

Hi Yogesh Porting is not reflected at all still the old dialog is visible. Please check and resend the updated patch. On Mon, Jul 5, 2021 at 8:40 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for extension port dialogue. > > Thanks, > Yogesh

[pgAdmin][Patch] - Housekeeping #6582 - [React] Port Extension object to react

Hi, Please find the attached patch for extension port dialogue. Thanks, Yogesh Mahajan EnterpriseDB RM6582_v1.patch Description: Binary data

Re: [pgAdmin][Patch] - RM #5940 - Add support for Oauth 2 authentication

Hi Khushboo Following are the review comments: *Scenario *: AUTHENTICATION_SOURCES = ['oauth2', 'internal'] - Don't set the OAUTH2_DISPLAY_NAME, Login button shows 'Login with None' which should be change. Maybe placeholder like . - Enter the email address and password. Click on the "Lo

pgAdmin 4 commit: Don't use fuzzy matching when updating message catalo

Don't use fuzzy matching when updating message catalogs, to avoid issues where the number string substitution placeholders changes, per discussion. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fff4060b310b773fd673d17c91dbcd1f22cdf58a Modif

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi On Mon, Jul 5, 2021 at 1:40 PM Dave Page wrote: > > > On Fri, Jul 2, 2021 at 8:41 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> +1 for --no-fuzzy-matching for updating translations. >> >> On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> w

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

On Fri, Jul 2, 2021 at 8:41 PM Rahul Shirsat wrote: > +1 for --no-fuzzy-matching for updating translations. > > On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 30,

Re: [patch][pgAdmin] RM6550 5.4 running on kubernetes fails to log in even with the right environment variables defined

Thanks, the patch applied. On Sat, Jul 3, 2021 at 1:08 AM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which resolves the login issue for a user > having a non-existing email id. > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Tha

pgAdmin 4 commit: Resolve the log in issue for a user having a non-exis

Resolve the log in issue for a user having a non-existing email id 1) Added CHECK_EMAIL_DELIVERABILITY & SECURITY_EMAIL_VALIDATOR_ARGS. 2) Added test cases for deliverability check. Fixes #6550 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif