Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi Dave / Aditya, For a time being, Let's make a call to gettext conditional instead of passing dynamic parameters for this scenario at least. With this, we won't be touching the *.po files and translations will do its task smoothly. I have already checked for the string with weird unprintable cha

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

On Tue, Jun 29, 2021 at 2:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote: > >> >> >> On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Dave, >>> >>> Somehow, the new

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi, On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote: > > > On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Dave, >> >> Somehow, the new text strings are added to PO with incorrect >> translations. That is causing the issue. >> Either they shoul

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Dave, > > Somehow, the new text strings are added to PO with incorrect translations. > That is causing the issue. > Either they should be empty or fixed. > Then the source problem should be fixed. There

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Dave, Somehow, the new text strings are added to PO with incorrect translations. That is causing the issue. Either they should be empty or fixed. On Tue, Jun 29, 2021 at 7:01 PM Dave Page wrote: > Hi > > Please send the patch without updates to the po files. Those get updated > as part of the r

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi Please send the patch without updates to the po files. Those get updated as part of the release process. Thanks. On Tue, Jun 29, 2021 at 2:00 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Thanks Aditya for pointing out the issue. Please find the attached patch >

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi Rahul, I did "make msg-extract" and "make msg-update" and looking at the PO files I think it is not updated correctly. For instance, the below message has msgstr without %s. I corrected it and the error was gone. #: pgadmin/browser/server_groups/servers/roles/static/js/role.js:766 #, fuzzy, py

pgAdmin 4 commit: Branch refs/heads/React_Porting was removed

Branch refs/heads/React_Porting was removed.

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

Thanks, the patch applied. On Mon, Jun 28, 2021 at 3:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. Attached is the revised patch. > > On Mon, Jun 28, 2021 at 2:50 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wr

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi On Tue, Jun 29, 2021 at 4:38 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > I feel gettext sometimes won't escape the characters as it should be. > > I now tried to escape those using some utils. > That won't work either. The string being passed to gettext() *must* be in the gett