Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
I feel gettext sometimes won't escape the characters as it should be. I now tried to escape those using some utils. Please find the updated patch. On Mon, Jun 28, 2021 at 9:33 PM Dave Page wrote: > Hi > > On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote:

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Dave Page
Hi On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for fixation of jenkins failure. > That won't work - you can't include variables (or string building operations) in the first argument to gettext calls, as t

[patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for fixation of jenkins failure. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. jenkins_failure_fix.patch Description: Binary data

pgAdmin 4 commit: Fix typo in filename.

2021-06-28 Thread Dave Page
Fix typo in filename. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9786215978c07298a0d595e5837c4dd2907ae41 Modified Files -- web/pgadmin/misc/static/explain/js/explain.js | 2 +- web/pgadmin/misc/static/

pgAdmin 4 commit: Added support for Reassign/Drop Owned for login roles

2021-06-28 Thread Akshay Joshi
Added support for Reassign/Drop Owned for login roles. Fixes #3893 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fe52b9cfec6d283724dfc5877caaf1da729daf9 Author: Rahul Shirsat Modified Files -- docs/en_US/images/role_drop_dialog

pgAdmin 4 commit: Fixed directory selection issue with the folder dialo

2021-06-28 Thread Akshay Joshi
Fixed directory selection issue with the folder dialog. Fixes #6536 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c6d00d54576b9475cf502c402dfda8db5f04b12 Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_5_5.rst

Re: [pgAdmin][RM-6536]: Browse button: Directory issues

2021-06-28 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 28, 2021 at 6:30 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6536 > : Browse button: Directory > issues. > > > -- > *Thanks & Regards,* > *Nikh

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-06-28 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 28, 2021 at 2:00 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > On Thu, Jun 24, 2021 at 2:32 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >>- The context m

[pgAdmin][RM-6536]: Browse button: Directory issues

2021-06-28 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6536 : Browse button: Directory issues. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM-6536.patch Description

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

2021-06-28 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the revised patch. On Mon, Jun 28, 2021 at 2:50 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I made some changes to the core code that will be helpful for other nodes. > Please review. > > > On Thu, Ju

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

2021-06-28 Thread Aditya Toshniwal
Hi Hackers, I made some changes to the core code that will be helpful for other nodes. Please review. On Thu, Jun 24, 2021 at 5:39 PM Akshay Joshi wrote: > Thanks, the patch applied in the "React_Porting" branch. > > On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal < > aditya.toshni...@enterpr

pgAdmin 4 commit: Clarify when container config envvars may be ignored.

2021-06-28 Thread Dave Page
Clarify when container config envvars may be ignored. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6429a5b31a42e9228ce864b5736627ce1a6fc243 Modified Files -- docs/en_US/container_deployment.rst | 8 +++- 1 file changed, 7 ins