Re: [pgAdmin][RM-6541]: Setting 'Open in new browser tab' is missing.

2021-06-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 21, 2021 at 1:35 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6541 > : Setting 'Open in new > browser tab' is missing. > Resolved issue, If ENABL

Re: Feature Test failure fix

2021-06-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 21, 2021 at 10:32 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch which fixes the feature tests failure issue > due to binary path feature. > > Thanks, > Yogesh Mahajan > EnterpriseDB > -- *Thanks & Reg

pgAdmin 4 commit: Ensure that setting 'Open in new browser tab' should

2021-06-22 Thread Akshay Joshi
Ensure that setting 'Open in new browser tab' should be visible, it should not be based on the value of 'ENABLE_PSQL'. Fixes #6541 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2302a6c9bc194f0b78f74fae7828dcf30e6f9b8 Author: Nikhil Mohite

pgAdmin 4 commit: Fixed feature tests failure issue due to binary path

2021-06-22 Thread Akshay Joshi
Fixed feature tests failure issue due to binary path feature. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2486b79450e521c5e592ef0ba8441bc4b1e24539 Author: Yogesh Mahajan Modified Files -- .../pg_utilities_backup_restore_test.p

Re: [pgAdmin][RM-6489]: Query tool Execute/Refresh button disables after first click for empty query

2021-06-22 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 15, 2021 at 2:37 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6489 > : Query tool Execute/Refresh > button disables after first click for empty

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

2021-06-22 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for #6398.Detaching query editor panel > gives a blank white panel. > > > -- > Thanks & Regards, > Pradip Parkale > Software Engine

pgAdmin 4 commit: Fixed an issue where Execute/Refresh button should no

2021-06-22 Thread Akshay Joshi
Fixed an issue where Execute/Refresh button should not be disabled when we run the empty query. Fixes #6489 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a53362068488567607611614ce3d1d8bf1cb7b38 Author: Nikhil Mohite Modified Files ---

pgAdmin 4 commit: Fixed an issue where detaching the query editor panel

2021-06-22 Thread Akshay Joshi
Fixed an issue where detaching the query editor panel gives a blank white panel. Fixes #6398 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b52ef6eb0de0017b2c08e112743ecd56903490e Author: Pradip Parkale Modified Files -- docs/e

pgAdmin 4 commit: Fix path on windows. Fixes #6558

2021-06-22 Thread Dave Page
Fix path on windows. Fixes #6558 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09d8d0f36279f8dbc172f5fe60243c5f1872575f Modified Files -- docs/en_US/config_py.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin][RM-6505]: Changing connection using the Drop Down has lost default "maintenance" database auto-select functionality and tab-through functionality.

2021-06-22 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6505 : Changing connection using the Drop Down has lost default "maintenance" database auto-select functionality and tab-through functionality. This patch fixed the maintenance DB is not selected as the

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-06-22 Thread Pradip Parkale
Hi Hackers, Please ignore my previous email and find the attached patch. I have fixed some review comments given by Aditya. On Tue, Jun 22, 2021 at 2:21 PM Fred wrote: > nice ! > thanks > > fred > > > Le 22 juin 2021 09:08:05 GMT+02:00, Pradip Parkale < > pradip.park...@enterprisedb.com> a écrit

[pgAdmin][RM6388] Replace keyboard shortcut not working

2021-06-22 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to fix the replace shortcut in the query tool. Regarding international keyboards, there is no way in JS to detect a keyboard layout. CodeMirror also does not handle international keyboards. Neither it provides any way to handle keyboard events differently. I wi

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-06-22 Thread Fred
nice ! thanks fred Le 22 juin 2021 09:08:05 GMT+02:00, Pradip Parkale a écrit : >Hi Hackers, > >Please find the attached patch for # 6448. I have added a check to ignore >the subscription when the search type is 'All type' if the user doesn't >have access to subscription. > >-- >Thanks & Rega

[pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-06-22 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for # 6448. I have added a check to ignore the subscription when the search type is 'All type' if the user doesn't have access to subscription. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6448.patch Description: