[pgAdmin][RM6399]: Add panel option allows to add duplicate tabs.

2021-05-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6399. I have partially fixed the issue. I have set the limit of 1 so that user won't be able to add any duplicate panel. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6399.patch Description: Binary data

pgAdmin 4 commit: Fixed an issue where the filter 'Include/Exclude By S

2021-05-11 Thread Akshay Joshi
Fixed an issue where the filter 'Include/Exclude By Selection' not working for null values. Fixes #6392 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd7808a104b38b1e92bbcccebf1c10141b0ebb25 Modified Files -- docs/en_US/release_

pgAdmin 4 commit: Added missing validation for data type. Fixes #6407

2021-05-11 Thread Akshay Joshi
Added missing validation for data type. Fixes #6407 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4842d589a638764daf5d3cc365c08361e0c94f13 Modified Files -- .../servers/databases/schemas/types/static/js/type.js | 10

pgAdmin 4 commit: Update document and screenshot for 'Resize by data?'

2021-05-11 Thread Akshay Joshi
Update document and screenshot for 'Resize by data?' option. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11c541adc6331005ee2cef7839d6dc4d43d39465 Modified Files -- docs/en_US/images/preferences_sql_results_grid.png | Bin 116960

pgAdmin 4 commit: Fix width of table row.

2021-05-11 Thread Dave Page
Fix width of table row. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c746cfddfefcfa0d7a555c28b793968e4f2a4430 Modified Files -- docs/en_US/menu_bar.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Improve some strings.

2021-05-11 Thread Dave Page
Improve some strings. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b7f8d8298e9986c8f09f14dfb571fd46d65a8c6 Modified Files -- web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py | 8 +--- 1 file changed, 5 insertions(

Re: Fix some typos in docs and comments

2021-05-11 Thread Dave Page
Thanks! Patch committed. On Tue, May 11, 2021 at 10:03 AM huangj.f...@fujitsu.com < huangj.f...@fujitsu.com> wrote: > Hi, > > I have found some typos in docs and code comments. > The attached patch shows it. > > -- > Thanks && regards > HuangJ > > -- Dave Page Blog: https://pgsnake.blogspot.com

pgAdmin 4 commit: Fix a number of typos.

2021-05-11 Thread Dave Page
Fix a number of typos. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6f9aae61528c5d14a2c2f53dc387d880e033ec Author: huangj.f...@fujitsu.com Modified Files -- docs/en_US/column_dialog.rst

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-05-11 Thread Dave Page
Hi On Tue, May 11, 2021 at 9:02 AM Akshay Joshi wrote: > Hi Nikhil > > Following are the review comments: > > *GUI specific*: > >- We need a panel icon for PSQL like query tool, we can also add that >on the browser tree toolbar. >- PSQL Tool menu should be visible for all the child n

Fix some typos in docs and comments

2021-05-11 Thread huangj.f...@fujitsu.com
Hi, I have found some typos in docs and code comments. The attached patch shows it. -- Thanks && regards HuangJ fix-typo.diff Description: fix-typo.diff

pgAdmin 4 commit: Cleanup the install-node target so it just calls yarn

2021-05-11 Thread Dave Page
Cleanup the install-node target so it just calls yarn. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bc07c45f54282a9331f2ac6de85a8fd7892ac02 Modified Files -- Makefile | 11 +-- 1 file changed, 1 insertion(+), 10 deletion

Re: [pgAdmin][RM5477] Cache bust webpack chunk files

2021-05-11 Thread Akshay Joshi
Thanks, patch applied. On Tue, May 11, 2021 at 12:34 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to bust cache when chunk file content changes. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer

pgAdmin 4 commit: Added support for cache bust webpack chunk files. Fix

2021-05-11 Thread Akshay Joshi
Added support for cache bust webpack chunk files. Fixes #5477 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=058afad9ebddbf43f86af96f82322bf0fecd88e5 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_5_3.rst | 1

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-05-11 Thread Akshay Joshi
Hi Nikhil Following are the review comments: *GUI specific*: - We need a panel icon for PSQL like query tool, we can also add that on the browser tree toolbar. - PSQL Tool menu should be visible for all the child nodes of the database node. Follow the same as Query Tool. - PSQL ta

[pgAdmin][RM5477] Cache bust webpack chunk files

2021-05-11 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to bust cache when chunk file content changes. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM5477.patch Description: Binary data