Re: [pgAdmin][patch] RM6329 [SQL] bad child table DDL

2021-04-26 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 26, 2021 at 8:37 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hello Akshay, > > Please find the updated patch. > > On Mon, Apr 26, 2021 at 2:34 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Fri, Apr

Re: [pgAdmin][RM6385]: Backup on a shared server doesn't seem to work

2021-04-26 Thread Akshay Joshi
Thanks, patch applied. On Tue, Apr 27, 2021 at 11:48 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. I have added more checks so that it will > pick the correct shared server. > > On Thu, Apr 22, 2021 at 5:43 PM Akshay Joshi < > akshay.j

pgAdmin 4 commit: Fixed an issue where indexes showing TABLESPACE pg_de

2021-04-26 Thread Akshay Joshi
Fixed an issue where indexes showing TABLESPACE pg_default for partition SQL, which should not be shown. refs #6329 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5ef022ef56c650ceb0afc06ea0cf8a35404a87a Author: Rahul Shirsat Modified File

pgAdmin 4 commit: Added more checks so that it will pick the correct sh

2021-04-26 Thread Akshay Joshi
Added more checks so that it will pick the correct shared server. refs #6385 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7bab200e4d6ebbc6bd969014cefa64b85f22e383 Author: Pradip Parkale Modified Files -- web/pgadmin/browser/se

Re: [pgAdmin][RM6385]: Backup on a shared server doesn't seem to work

2021-04-26 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. I have added more checks so that it will pick the correct shared server. On Thu, Apr 22, 2021 at 5:43 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Apr 22, 2021 at 2:37 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi

Re: [pgAdmin][patch] RM6329 [SQL] bad child table DDL

2021-04-26 Thread Rahul Shirsat
Hello Akshay, Please find the updated patch. On Mon, Apr 26, 2021 at 2:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Apr 23, 2021 at 2:08 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find below patch which resolves the issue of inher

Re: [pgAdmin][RM6341] CSV download quotes numeric columns

2021-04-26 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 26, 2021 at 5:01 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch for #6251. I have fixed the issue caused due > to my initial patch. > > On Thu, Apr 22, 2021 at 5:42 PM Akshay Joshi < > akshay.jo...@enterp

pgAdmin 4 commit: Fixed an issue where long float values cause the rend

2021-04-26 Thread Akshay Joshi
Fixed an issue where long float values cause the rendering issue on the UI side. It's a regression of the original commit for 6341. refs #6341 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a302684f768949c1c781c4d3f367c2d4dcc3acc Author: Pr

Re: [pgAdmin][RM6341] CSV download quotes numeric columns

2021-04-26 Thread Pradip Parkale
Hi Akshay, Please find the updated patch for #6251. I have fixed the issue caused due to my initial patch. On Thu, Apr 22, 2021 at 5:42 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 20, 2021 at 10:54 AM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers,

pgAdmin 4 commit: Fixed an issue where schema diff does not create DROP

2021-04-26 Thread Akshay Joshi
Fixed an issue where schema diff does not create DROP DEFAULT statement for columns. Fixes #6377 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d6f077cf839a932fac72ddd6b51eddc91962605 Modified Files -- docs/en_US/release_notes_5

Re: [pgAdmin][patch] RM6329 [SQL] bad child table DDL

2021-04-26 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 23, 2021 at 2:08 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find below patch which resolves the issue of inherited key > constraint getting in partition SQL. > > Simultaneously, added the partition table's RLS policy, Trig

pgAdmin 4 commit: Fixed an issue where the wrong SQL is showing for the

2021-04-26 Thread Akshay Joshi
Fixed an issue where the wrong SQL is showing for the child partition tables. Fixes #6329 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b853bda2a27622c835817b911af8c538eaf659ea Author: Rahul Shirsat Modified Files -- docs/en_US

Re: [pgAdmin4][Patch] - RM 6158 - Logging into PostgreSQL servers with Kerberos Authentication

2021-04-26 Thread Akshay Joshi
Hi Khushboo I have applied your patch and started testing it in different scenarios. Following are the GUI review comments: - Update the comments about Kerberos support for AUTHENTICATION_SOURCES in config.py. - You will have to create a migration file again. Getting "Error: Multiple