Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab.

2021-02-09 Thread Nikhil Mohite
Hi Rahul, While reviewing the patch, found one observation with update privileges. 1. While creating a table add any privileges for any user and save. (e.g: Add Insert to user1) 2. Open table properties and update privileges for the same user by editing the privilege (e.g: Now Add Update to user1)

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-09 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> One jasmine test is failing, please fix that and resend the patch. >> > It was failing because

pgAdmin 4 commit: Updated the JS dependencies to the latest

2021-02-09 Thread Akshay Joshi
Updated the JS dependencies to the latest 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes, so updated multiple webpack plugins and changed the config accordingly. 2) Replaced iconfont-webpack-plugin with a more maintained webfonts-loader. 3) Replaced deprecated babel-

[pgAdmin4][Patch] - API Tests Tear-down Fix

2021-02-09 Thread Yogesh Mahajan
Hello, Please find a patch which fixes deletion of roles after api tests execution. Thanks, Yogesh Mahajan EnterpriseDB API_Tests_Tear_Down_Fix_v1.0 Description: Binary data

pgAdmin 4 commit: Fix filenames.

2021-02-09 Thread Dave Page
Fix filenames. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=589663d7d9cc9e0301169fb1c09ad06141ba9eef Modified Files -- pkg/debian/{README => README.md} | 0 pkg/docker/{README => README.md} | 0 pkg/linux/{README => README.md} |

pgAdmin 4 commit: A bunch of size optimisation for the container.

2021-02-09 Thread Dave Page
A bunch of size optimisation for the container. The new Rust requirement for the Cryptography module bloated it significantly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=884d9db54bf4a203ba18f129a4e23720020b15b0 Modified Files ---

Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

2021-02-09 Thread Murtuza Zabuawala
Hi, It will break the WSGI. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi wrote: > Use 'sys.executable' to get the absolute path of the executable binary for > the Python interpreter instead of existing complex

Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab.

2021-02-09 Thread Akshay Joshi
Hi Nikhil Can you please review the patch thoroughly? On Mon, Feb 8, 2021 at 3:28 PM Rahul Shirsat wrote: > Akshay, > > Removed some whitespace warnings. While this new patch is applied there > are still 2 unknown whitespace warnings which are pointing to the wrong > location. > > Could you ple

Re: [pgAdmin][RM-6157]: UI issue in delete records.

2021-02-09 Thread Nikhil Mohite
Hi Akshay/ Team, Please find the updated patch for RM-6157. 1. Resolved issue related to strikeout (Red strike-through line which indicates delete records) is getting removed on scrolling for index(Serial) column of the table. Regards, Nikhil Mohite. On Fri, Feb 5, 2021 at 2:16 PM Akshay Joshi

Re: [pgAdmin][RM6207] Update JS dependencies

2021-02-09 Thread Akshay Joshi
Hi Aditya One jasmine test is failing, please fix that and resend the patch. On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to update the JS dependencies to latest. Changes > include: > 1) Migrate from webpack 4

Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab

2021-02-09 Thread Akshay Joshi
Thanks, patch applied. On Tue, Feb 9, 2021 at 2:23 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hello Akshay, > > The previous patch will fix the dashboard issue also. > > On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >>

pgAdmin 4 commit: Ensure that ajax request for Dashboard, Statistics, D

2021-02-09 Thread Akshay Joshi
Ensure that ajax request for Dashboard, Statistics, Dependencies, and Dependents should not be raised until the panel will be in focus. refs #5091 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=617440e1db3234874cf16b91206fe97a83a26d46 Author:

pgAdmin 4 commit: Use 'sys.executable' to get theĀ absolute path of the

2021-02-09 Thread Akshay Joshi
Use 'sys.executable' to get theĀ absolute path of the executable binary for the Python interpreter instead of existing complex logic. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d612c5 Modified Files -

Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab

2021-02-09 Thread Aditya Toshniwal
Hello Akshay, The previous patch will fix the dashboard issue also. On Tue, Feb 9, 2021 at 12:41 PM Akshay Joshi wrote: > Hi Aditya > > Please fix the issue for Dashboard API calls as well and send the patch > again. > > On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal < > aditya.toshni...@enter