Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.

2021-02-03 Thread Akshay Joshi
Hi Pradip I haven't started reviewing your patch but seems you haven't written test cases for schema diff. Please add and then submit the patch again. On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for publ

Re: [pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX.

2021-02-03 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 3, 2021 at 6:16 PM Nikhil Mohite wrote: > Hi Team, > > Please find the attached patch for RM-5809 > : Filtered Rows along with > Shift+Enter submit can result in confusing UX. > Added set focus to filter text editor o

pgAdmin 4 commit: Fixed an issue where the focus is not properly set on

2021-02-03 Thread Akshay Joshi
Fixed an issue where the focus is not properly set on the filter text editor after closing the error dialog. Fixes #5809 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14036b7aeb608a5a23bf40fc3b0465526ccb7b36 Author: Nikhil Mohite Modified

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-02-03 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 3, 2021 at 2:22 PM Nikhil Mohite wrote: > Hi Team, > > Please find the updated patch for RM-6143. > > > Regards, > Nikhil Mohite. > > On Mon, Feb 1, 2021 at 2:52 PM Dave Page wrote: > >> Hi >> >> On Mon, Feb 1, 2021 at 7:51 AM Nikhil Mohite < >> nikhil.moh...@

pgAdmin 4 commit: Fixed an issue where shared server entries not gettin

2021-02-03 Thread Akshay Joshi
Fixed an issue where shared server entries not getting deleted from SQLite database if the user gets deleted. Fixes #6143 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02c3863e8cf773c6dfcae6f0398c451fba7c3f76 Author: Nikhil Mohite Modified

Re: pgAdmin: ERD Tool a suggestion.

2021-02-03 Thread Aditya Toshniwal
Hi Hitesh, On Wed, Feb 3, 2021 at 8:55 PM Hitesh Patel wrote: > Dear pgAdmin Hackers, > > I notice in the latest version of pgAdmin (4.30) there is a ERD beta tool. > > I wanted to suggest a feature which would be most helpful for database > developers (not sure if you already working on this).

[pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.

2021-02-03 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for publication and subscription support in Schema Diff. Also, added the dependencies for publication and subscription. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6153.patch Description: Binary data

pgAdmin: ERD Tool a suggestion.

2021-02-03 Thread Hitesh Patel
Dear pgAdmin Hackers, I notice in the latest version of pgAdmin (4.30) there is a ERD beta tool. I wanted to suggest a feature which would be most helpful for database developers (not sure if you already working on this). A lot of times I need to propose changes to the database and the databas

pgAdmin 4 commit: Try to make the NWJS download a little more reliable.

2021-02-03 Thread Dave Page
Try to make the NWJS download a little more reliable. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6683522491f4f09a6e713b8469e6e39dff406d9b Modified Files -- Make.bat | 25 +++-- 1 file changed, 23 insertions(

[pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX.

2021-02-03 Thread Nikhil Mohite
Hi Team, Please find the attached patch for RM-5809 : Filtered Rows along with Shift+Enter submit can result in confusing UX. Added set focus to filter text editor on the closing of the error dialog. -- *Thanks & Regards,* *Nikhil Mohite* *Software Eng

Re: [pgAdmin][patch] Use unique DB name in ERD API test cases

2021-02-03 Thread Akshay Joshi
Thanks, patch applied. On Wed, Feb 3, 2021 at 4:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use unique DB names in ERD API test cases to > avoid conflict when running test cases in parallel. > Please review. > > -- > Thanks, > Adit

pgAdmin 4 commit: Use unique database name in ERD API test cases.

2021-02-03 Thread Akshay Joshi
Use unique database name in ERD API test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee679e39e5c4304fa0c7c166534ac767f9aeef93 Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/erd/tests/test_close.py | 5

pgAdmin 4 commit: Don't include unnecessary doc files in the build.

2021-02-03 Thread Dave Page
Don't include unnecessary doc files in the build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db1eb75298c8cfe8d19b3ff870b6aa70c2cfa3f6 Modified Files -- Make.bat | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Upgrade pip in a windows compatible way.

2021-02-03 Thread Dave Page
Upgrade pip in a windows compatible way. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb3801a5e8f8a5fcbdb38873bcd475c82202ce84 Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin][patch] Use unique DB name in ERD API test cases

2021-02-03 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to use unique DB names in ERD API test cases to avoid conflict when running test cases in parallel. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a

pgAdmin 4 commit: Fixed jasmine test cases and added some missing messa

2021-02-03 Thread Akshay Joshi
Fixed jasmine test cases and added some missing messages for disabled menus. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e90350e442f867242d47565d0afff050c910f57 Author: Pramod Ahire Modified Files -- .../schemas/packages/stat

pgAdmin 4 commit: Make Statistics, Dependencies, Dependants tabs closab

2021-02-03 Thread Akshay Joshi
Make Statistics, Dependencies, Dependants tabs closable and the user can add them back using the 'Add panel' option. Fixes #5091 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=73b6b95fbc3efd7d273d6ae37edeecaa394b3e7d Author: Aditya Toshniwal

pgAdmin 4 commit: 1) Ensure that all the python packages will take the

2021-02-03 Thread Akshay Joshi
1) Ensure that all the python packages will take the latest until a major version. 2) Removed few packages which were dependencies of some other package. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18f055fa5ed9c579c0d47cca0009f607310b025d