Re: [pgAdmin][RM6193] Should warn before closing if opened in a new tab

2021-02-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Feb 1, 2021 at 2:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > ERD will now throw warning before closing unsaved changes if opened in a > new tab. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Soft

Re: [pgAdmin4][Patch]: Dependency tab fix

2021-02-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Feb 1, 2021 at 5:46 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the dependency tab loading issue > with the database name having special characters like (',"" etc...) > > Thanks, > Khushboo > -- *Tha

pgAdmin 4 commit: Ensure that ERD throws a warning before closing unsav

2021-02-01 Thread Akshay Joshi
Ensure that ERD throws a warning before closing unsaved changesĀ if open in a new tab. Fixes #6193 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=75f887f5dcc76c18f8fcd5abab5988560efe7ffc Author: Aditya Toshniwal Modified Files --

pgAdmin 4 commit: Fixed dependency tab loading issue when database name

2021-02-01 Thread Akshay Joshi
Fixed dependency tab loading issue when database name having special characters. refs #6087 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7214b7cfe18aeaba45fc3a70492b660de7faa30 Author: Khushboo Vashi Modified Files -- .../ser

pgAdmin 4 commit: Use the latest Gunicorn.

2021-02-01 Thread Dave Page
Use the latest Gunicorn. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=960433dd90f248ad3364f375f582dfb11f5dc4d4 Modified Files -- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Rotate the logfile in the container distribution. Fix

2021-02-01 Thread Dave Page
Rotate the logfile in the container distribution. Fixes #6170 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e10dd6a80f1ffbcd6eee0e8fc7f95e5fd6fe159b Modified Files -- Dockerfile | 4 +++- docs/en_US/release_n

pgAdmin 4 commit: Make sure pgAdmin can find the root certificates for

2021-02-01 Thread Dave Page
Make sure pgAdmin can find the root certificates for upgrade checks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=32e3da7857dc61344371876f02b5e6f546316f19 Modified Files -- pkg/docker/entrypoint.sh | 1 + 1 file changed, 1 insert

pgAdmin 4 commit: Remove the PG 9.5 utilities, as it'll be out of suppo

2021-02-01 Thread Dave Page
Remove the PG 9.5 utilities, as it'll be out of support by the next release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a4ba132ad601c902a19c2f8540251c01087a8ee Modified Files -- Dockerfile | 5 - d

pgAdmin 4 commit: Remove some unnecessary files from the doc build to s

2021-02-01 Thread Dave Page
Remove some unnecessary files from the doc build to save space. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e7ca8c4b0757c8df30c19565313d9bc3985e12d Modified Files -- Dockerfile | 4 1 file changed, 4 insertions(+)

UBI based container patch

2021-02-01 Thread Dave Page
* Do not commit this! * The dev team have discussed moving the pgAdmin container to be based on Redhat's UBI instead of Alpine Linux. I got some time today to work on that, and a patch is attached for interest/archives. Whilst the build process is arguably cleaner with this patch, plus it would b

pgAdmin 4 commit: Ensure the bundle identifier matches what's in Info.p

2021-02-01 Thread Dave Page
Ensure the bundle identifier matches what's in Info.plist. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dc6181d1e0908044672086ffd14c6ad2d488bfa Modified Files -- pkg/mac/build-functions.sh | 12 pkg/mac/codesign.con

[pgAdmin4][Patch]: Dependency tab fix

2021-02-01 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the dependency tab loading issue with the database name having special characters like (',"" etc...) Thanks, Khushboo dependency_tab_fix.patch Description: Binary data

pgAdmin 4 commit: Make sure the doc builder has the dependencies it nee

2021-02-01 Thread Dave Page
Make sure the doc builder has the dependencies it needs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=921c0ac71ab5aca5686f91e176932a91a3b0e28d Modified Files -- Dockerfile | 18 +++--- 1 file changed, 7 insertions(+),

pgAdmin 4 commit: Use the same retry logic we use on Linux for grabbing

2021-02-01 Thread Dave Page
Use the same retry logic we use on Linux for grabbing nwjs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad656a9d4125591d19b5893769f069100c498397 Modified Files -- pkg/mac/build-functions.sh | 31 +++

pgAdmin 4 commit: Default to Python 3.9.1

2021-02-01 Thread Dave Page
Default to Python 3.9.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56cc1f0aaf55cd8d5a271bc24bbce4bbf09db9dc Modified Files -- pkg/mac/build.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin][RM5912]: Added support for Logical Replication.

2021-02-01 Thread Akshay Joshi
Thanks, the patch applied with some fixes. On Wed, Jan 27, 2021 at 11:09 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. I have fixed almost all issues, some are > not possible. > > On Sat, Jan 16, 2021 at 4:29 PM Akshay Joshi < > akshay.j

pgAdmin 4 commit: Added support for Logical Replication. Fixes #5912

2021-02-01 Thread Akshay Joshi
Added support for Logical Replication. Fixes #5912 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf56a6723b1acf625dd35503cda207a34d55824b Author: Pradip Parkale Modified Files -- docs/en_US/release_notes_5_0.rst

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-02-01 Thread Dave Page
Hi On Mon, Feb 1, 2021 at 7:51 AM Nikhil Mohite wrote: > Hi Dave/ Team, > > As per the suggestions I have created a sample UI for change ownership of > shared servers before deleting the user(only for admin user). > [image: shared_server_change_ownsership.png] > The user list will contain all ad

[pgAdmin][RM6193] Should warn before closing if opened in a new tab

2021-02-01 Thread Aditya Toshniwal
Hi Hackers, ERD will now throw warning before closing unsaved changes if opened in a new tab. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM6193.patch Description: Binar